From: Jarkko Nikula <jhnikula@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Tony Lindgren <tony@atomide.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: McBSP: Fix possible port lockout
Date: Thu, 17 Dec 2009 09:19:18 +0200 [thread overview]
Message-ID: <20091217091918.1ae3c388.jhnikula@gmail.com> (raw)
In-Reply-To: <200912161716.30041.jkrzyszt@tis.icnet.pl>
On Wed, 16 Dec 2009 17:16:28 +0100
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:
> More and more looking at this, I think that omap_mcbsp_request() should be
> cleaned up frist in respect of freeing resources on error before we put any
> new functionality there.
>
Good idea.
> I'm not sure if it is really required to revert any
> mcbsp->pdata->ops->request() or omap34xx_mcbsp_request() applied changes by
> calling mcbsp->pdata->ops->free() or omap34xx_mcbsp_free() from here.
>
It is allways worth/must to keep request and free calls in balance as
your patch does. In this case some clocks may left running
(omap1_mcbsp_request/_free) or wakeup behavior (34xx) otherwise.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2009-12-17 7:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 16:16 [PATCH] OMAP: McBSP: Fix possible port lockout Janusz Krzysztofik
2009-12-17 7:19 ` Jarkko Nikula [this message]
2009-12-17 9:06 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091217091918.1ae3c388.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox