From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [GIT PULL] omap build fixes Date: Thu, 17 Dec 2009 09:26:01 -0800 Message-ID: <20091217172600.GY4575@atomide.com> References: <20091216223520.GV4575@atomide.com> <4B2A1635.1080505@blueyonder.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:55935 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765038AbZLQR0I (ORCPT ); Thu, 17 Dec 2009 12:26:08 -0500 Content-Disposition: inline In-Reply-To: <4B2A1635.1080505@blueyonder.co.uk> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Sid Boyce Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org * Sid Boyce [091217 03:29]: > uImage built, so EHCI build problem definitely fixed, just one error > I've previously encountered when building modules. > slipstream:/home/lancelot/ftp/dec09/OMAP/omap-fixes-for-linus # ARCH=arm > make -j 4 CROSS_COMPILE=/opt/arm-2009q3/bin/arm-none-eabi- modules > scripts/kconfig/conf -s arch/arm/Kconfig > CHK include/linux/version.h > SYMLINK include/asm -> include/asm-arm > make[1]: `include/asm-arm/mach-types.h' is up to date. > CHK include/linux/utsrelease.h > CALL scripts/checksyscalls.sh > :1523: warning: #warning syscall recvmmsg not implemented > Building modules, stage 2. > MODPOST 99 modules > ERROR: "omap_ctrl_writel" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined! > ERROR: "omap_ctrl_readl" [sound/soc/omap/snd-soc-omap-mcbsp.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 Hmm. I'm not seeing this in any of the defconfigs, so I guess this happens with ASoC complied as a module. But instead of exporting omap_ctrl_read/write, we need to get rid of omap_ctrl_read/write stuff in the drivers. It seems that omap_mcbsp_dai_set_clks_src() should be implemented in the clock framework instead. Regards, Tony