From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext Candelaria Villareal, Jorge" <x0107209@ti.com>
Cc: "Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 2/3] ASoC: OMAP4: Add support for McPDM
Date: Fri, 18 Dec 2009 11:33:38 +0200 [thread overview]
Message-ID: <20091218093338.GA31755@nokia.com> (raw)
In-Reply-To: <2256F256009DAA4CBE661E9F41EAC84B8BA0AA88@dlee01.ent.ti.com>
Hi,
On Fri, Dec 18, 2009 at 03:23:14AM +0100, ext Candelaria Villareal, Jorge wrote:
>Is this because if two interrupts were set, my approach would
>not recognize it as one of the cases and exit without processing
>the interrupt?
you don't have a break in your switch. your approach would go through
all irq cases no matter what :-p
>> what ? so even if you don't have a platform_device you register the
>> driver ??
>
>So, it would be better if I had declared a platform_device structure
>in .../arch/arm/plat-omap/devices.c, and register its resources (irq
>and memory base) in there?
IMO yeah. It would look cleaner. But McBSP is the same mess so I don't
know what the ALSA people will say. Jarkko Nikula probably has some
ideas as he did most of the OMAP ASoC implementation.
--
balbi
next prev parent reply other threads:[~2009-12-18 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 19:40 [PATCH 2/3] ASoC: OMAP4: Add support for McPDM Candelaria Villareal, Jorge
2009-12-17 20:28 ` Felipe Balbi
2009-12-18 2:23 ` Candelaria Villareal, Jorge
2009-12-18 9:33 ` Felipe Balbi [this message]
2009-12-18 10:54 ` Mark Brown
2009-12-18 17:01 ` Candelaria Villareal, Jorge
2009-12-20 14:19 ` Felipe Balbi
2009-12-20 18:58 ` Felipe Balbi
2009-12-21 22:50 ` Candelaria Villareal, Jorge
2009-12-18 10:51 ` [alsa-devel] " Mark Brown
2009-12-18 11:13 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218093338.GA31755@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=x0107209@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox