Re: [PATCH 2/3] ASoC: OMAP4: Add support for McPDM

Mark Brown
2009-12-18T10:54:35Z

On Fri, Dec 18, 2009 at 11:33:38AM +0200, Felipe Balbi wrote:
> On Fri, Dec 18, 2009 at 03:23:14AM +0100, ext Candelaria Villareal, Jorge wrote:

> >So, it would be better if I had declared a platform_device structure
> >in .../arch/arm/plat-omap/devices.c, and register its resources (irq
> >and memory base) in there?

> IMO yeah. It would look cleaner. But McBSP is the same mess so I don't
> know what the ALSA people will say. Jarkko Nikula probably has some
> ideas as he did most of the OMAP ASoC implementation.

That's fine from an ASoC point of view. The McBSP code predates the
ability to have platform devices for the individual components of the
ASoC subsystem so it's jumping through some hoops that are no longer
required.