Re: [PATCH 2/3] ASoC: OMAP4: Add support for McPDM

Felipe Balbi
2009-12-18T09:33:38Z

Hi,

On Fri, Dec 18, 2009 at 03:23:14AM +0100, ext Candelaria Villareal, Jorge wrote:
>Is this because if two interrupts were set, my approach would
>not recognize it as one of the cases and exit without processing
>the interrupt?

you don't have a break in your switch. your approach would go through
all irq cases no matter what :-p

>> what ? so even if you don't have a platform_device you register the
>> driver ??
>
>So, it would be better if I had declared a platform_device structure
>in .../arch/arm/plat-omap/devices.c, and register its resources (irq
>and memory base) in there?

IMO yeah. It would look cleaner. But McBSP is the same mess so I don't
know what the ALSA people will say. Jarkko Nikula probably has some
ideas as he did most of the OMAP ASoC implementation.

--
balbi