Re: [PATCH 2/3] ASoC: OMAP4: Add support for McPDM

Candelaria Villareal, Jorge
2009-12-18T17:01:19Z

Felipe Balbi wrote:
> Hi,
>
> On Fri, Dec 18, 2009 at 03:23:14AM +0100, ext Candelaria
> Villareal, Jorge wrote:
> >Is this because if two interrupts were set, my approach would
> >not recognize it as one of the cases and exit without processing
> >the interrupt?
>
> you don't have a break in your switch. your approach would go through
> all irq cases no matter what :-p

Mmm... But it _does_ have some breaks. Besides, I am still unsure that
if structure should be used here. Code would be duplicated, for example,
DN_IRQ_FULL and DN_IRQ_EMPTY share the same procedure to acknowledge
the request.