* mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t
[not found] <1261998172-29760-1-git-send-email-felipe.balbi@nokia.com>
@ 2009-12-28 11:02 ` Felipe Balbi
2009-12-28 20:01 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2009-12-28 11:02 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Andrew Morton, Felipe Balbi, Tony Lindgren, linux-omap
commit 239007b8440abff689632f50cdf0f2b9e895b534 converted
the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq
was left aside on the conversion.
Cc: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
resending because it wasn't applied before
drivers/mfd/twl4030-irq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
index 20d29ba..9df9a5a 100644
--- a/drivers/mfd/twl4030-irq.c
+++ b/drivers/mfd/twl4030-irq.c
@@ -568,12 +568,12 @@ static void twl4030_sih_do_edge(struct work_struct *work)
bytes[byte] &= ~(0x03 << off);
- spin_lock_irq(&d->lock);
+ raw_spin_lock_irq(&d->lock);
if (d->status & IRQ_TYPE_EDGE_RISING)
bytes[byte] |= BIT(off + 1);
if (d->status & IRQ_TYPE_EDGE_FALLING)
bytes[byte] |= BIT(off + 0);
- spin_unlock_irq(&d->lock);
+ raw_spin_unlock_irq(&d->lock);
edge_change &= ~BIT(i);
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t
2009-12-28 11:02 ` mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t Felipe Balbi
@ 2009-12-28 20:01 ` Tony Lindgren
2010-01-05 19:34 ` Samuel Ortiz
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2009-12-28 20:01 UTC (permalink / raw)
To: Felipe Balbi
Cc: Linux Kernel Mailing List, Andrew Morton, linux-omap,
Samuel Ortiz
* Felipe Balbi <felipe.balbi@nokia.com> [091228 03:04]:
> commit 239007b8440abff689632f50cdf0f2b9e895b534 converted
> the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq
> was left aside on the conversion.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: linux-omap@vger.kernel.org
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
>
> ---
>
> resending because it wasn't applied before
This should go via Samuel as it's MFD related.
Acked-by: Tony Lindgren <tony@atomide.com>
>
> drivers/mfd/twl4030-irq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 20d29ba..9df9a5a 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -568,12 +568,12 @@ static void twl4030_sih_do_edge(struct work_struct *work)
>
> bytes[byte] &= ~(0x03 << off);
>
> - spin_lock_irq(&d->lock);
> + raw_spin_lock_irq(&d->lock);
> if (d->status & IRQ_TYPE_EDGE_RISING)
> bytes[byte] |= BIT(off + 1);
> if (d->status & IRQ_TYPE_EDGE_FALLING)
> bytes[byte] |= BIT(off + 0);
> - spin_unlock_irq(&d->lock);
> + raw_spin_unlock_irq(&d->lock);
>
> edge_change &= ~BIT(i);
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t
2009-12-28 20:01 ` Tony Lindgren
@ 2010-01-05 19:34 ` Samuel Ortiz
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2010-01-05 19:34 UTC (permalink / raw)
To: Tony Lindgren
Cc: Felipe Balbi, Linux Kernel Mailing List, Andrew Morton,
linux-omap
Hi Tony,
On Mon, Dec 28, 2009 at 12:01:45PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <felipe.balbi@nokia.com> [091228 03:04]:
> > commit 239007b8440abff689632f50cdf0f2b9e895b534 converted
> > the spinlock_t to raw_spinlock_t. Unfortunately twl4030-irq
> > was left aside on the conversion.
> >
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: linux-omap@vger.kernel.org
> > Acked-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
> >
> > ---
> >
> > resending because it wasn't applied before
>
> This should go via Samuel as it's MFD related.
Linus applied it to his tree directly.
Cheers,
Samuel.
> Acked-by: Tony Lindgren <tony@atomide.com>
>
>
> >
> > drivers/mfd/twl4030-irq.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> > index 20d29ba..9df9a5a 100644
> > --- a/drivers/mfd/twl4030-irq.c
> > +++ b/drivers/mfd/twl4030-irq.c
> > @@ -568,12 +568,12 @@ static void twl4030_sih_do_edge(struct work_struct *work)
> >
> > bytes[byte] &= ~(0x03 << off);
> >
> > - spin_lock_irq(&d->lock);
> > + raw_spin_lock_irq(&d->lock);
> > if (d->status & IRQ_TYPE_EDGE_RISING)
> > bytes[byte] |= BIT(off + 1);
> > if (d->status & IRQ_TYPE_EDGE_FALLING)
> > bytes[byte] |= BIT(off + 0);
> > - spin_unlock_irq(&d->lock);
> > + raw_spin_unlock_irq(&d->lock);
> >
> > edge_change &= ~BIT(i);
> > }
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-05 19:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1261998172-29760-1-git-send-email-felipe.balbi@nokia.com>
2009-12-28 11:02 ` mfd: twl4030-irq: irq_desc->lock converted to raw_spinlock_t Felipe Balbi
2009-12-28 20:01 ` Tony Lindgren
2010-01-05 19:34 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox