From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init
Date: Tue, 29 Dec 2009 12:02:06 -0800 [thread overview]
Message-ID: <20091229200206.GJ3512@atomide.com> (raw)
In-Reply-To: <1262116575.28789.84.camel@gandalf>
* Felipe Balbi <me@felipebalbi.com> [091229 11:54]:
> On Tue, 2009-12-29 at 21:53 +0200, Felipe Balbi wrote:
> > On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote:
> > > * Felipe Balbi <felipe.balbi@nokia.com> [091228 03:10]:
> > > > each board might have a different charge pump and
> > > > thus able to source more or less current on vbus
> > > > so let power be easily configurable.
> > >
> > > In order to justify merging this as a fix, can you please update
> > > the subject and description to describe that this fixes the
> > > the power value ?
> >
> > for sure, doing it right now.
>
> How about now ? (did the same to the board mode)
>
> commit 860a17d3dc78cc8c640a83ade83dd0ec4f1217f1
> Author: Felipe Balbi <felipe.balbi@nokia.com>
> Date: Mon Dec 28 00:46:19 2009 +0200
>
> arm: omap: musb: fix board mode by passing it to usb_musb_init
>
> each board will have a different mode which is peculiar
> to that board.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
>
> commit 86b92c438109a95c20fad62804b4b8040f3676b7
> Author: Felipe Balbi <felipe.balbi@nokia.com>
> Date: Mon Dec 28 00:30:42 2009 +0200
>
> arm: omap: musb: fix board power budget by passing it to
> usb_musb_init
>
> each board might have a different charge pump and
> thus able to source more or less current on vbus
> so let power be easily configurable.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
Sounds good to me.
Thanks,
Tony
next prev parent reply other threads:[~2009-12-29 20:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 11:09 [PATCH 0/8] musb patches Felipe Balbi
2009-12-28 11:09 ` [PATCH 1/8] arm: omap: musb: remove unused data Felipe Balbi
2009-12-28 11:09 ` [PATCH 2/8] arm: omap: musb: we can use clk framework Felipe Balbi
2009-12-28 11:09 ` [PATCH 3/8] arm: omap: musb: remove unused soft_con field Felipe Balbi
2009-12-28 11:09 ` [PATCH 4/8] arm: omap: musb: remove unused dma data Felipe Balbi
2009-12-28 11:09 ` [PATCH 5/8] arm: omap: musb: ioremap only what's ours Felipe Balbi
2009-12-28 11:09 ` [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init Felipe Balbi
2009-12-29 19:51 ` Tony Lindgren
2009-12-29 19:53 ` Felipe Balbi
2009-12-29 19:56 ` Felipe Balbi
2009-12-29 20:02 ` Tony Lindgren [this message]
2009-12-29 20:55 ` Tony Lindgren
2009-12-28 11:09 ` [PATCH 7/8] arm: omap: musb: pass board mode " Felipe Balbi
2009-12-29 19:51 ` Tony Lindgren
2009-12-30 4:44 ` Gupta, Ajay Kumar
2009-12-30 12:06 ` Felipe Balbi
2009-12-28 11:09 ` [PATCH 8/8] arm: omap: musb: remove unnecessary return Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091229200206.GJ3512@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox