From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 6/8] arm: omap: musb: pass power to usb_musb_init Date: Tue, 29 Dec 2009 12:02:06 -0800 Message-ID: <20091229200206.GJ3512@atomide.com> References: <1261998590-6639-1-git-send-email-felipe.balbi@nokia.com> <1261998590-6639-7-git-send-email-felipe.balbi@nokia.com> <20091229195112.GF3512@atomide.com> <1262116381.28789.83.camel@gandalf> <1262116575.28789.84.camel@gandalf> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:61319 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752125AbZL2UCN (ORCPT ); Tue, 29 Dec 2009 15:02:13 -0500 Content-Disposition: inline In-Reply-To: <1262116575.28789.84.camel@gandalf> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: Felipe Balbi , Linux OMAP Mailing List * Felipe Balbi [091229 11:54]: > On Tue, 2009-12-29 at 21:53 +0200, Felipe Balbi wrote: > > On Tue, 2009-12-29 at 11:51 -0800, Tony Lindgren wrote: > > > * Felipe Balbi [091228 03:10]: > > > > each board might have a different charge pump and > > > > thus able to source more or less current on vbus > > > > so let power be easily configurable. > > > > > > In order to justify merging this as a fix, can you please update > > > the subject and description to describe that this fixes the > > > the power value ? > > > > for sure, doing it right now. > > How about now ? (did the same to the board mode) > > commit 860a17d3dc78cc8c640a83ade83dd0ec4f1217f1 > Author: Felipe Balbi > Date: Mon Dec 28 00:46:19 2009 +0200 > > arm: omap: musb: fix board mode by passing it to usb_musb_init > > each board will have a different mode which is peculiar > to that board. > > Signed-off-by: Felipe Balbi > > commit 86b92c438109a95c20fad62804b4b8040f3676b7 > Author: Felipe Balbi > Date: Mon Dec 28 00:30:42 2009 +0200 > > arm: omap: musb: fix board power budget by passing it to > usb_musb_init > > each board might have a different charge pump and > thus able to source more or less current on vbus > so let power be easily configurable. > > Signed-off-by: Felipe Balbi Sounds good to me. Thanks, Tony