Re: [PATCH 1/4] OMAP2: clock: clk2xxx.c doesn't compile if CPUFREQ is enabled

Paul Walmsley
2010-01-05T16:03:20Z

On Tue, 5 Jan 2010, Felipe Balbi wrote:

> and you forgot to change the variable definition...

Thanks, looks like I sent an older version of the series. I will resend.

> The variable defined is called rate but you use sys_ck_rate. I used rate,
> because that's what other functions are using and I wanted to keep the code
> consistent.

Did you examine the other functions omap2_round_to_table_rate() and
omap2_select_table_rate()?

What advantage is there to keeping this variable named "rate", which is
less specific given that this function also deals with DPLL rates, MPU
rates, and crystal rates?

- Paul