Re: [PATCH 3/4] OMAP2 clock: dynamically allocate CPUFreq frequency table

Paul Walmsley
2010-01-05T16:22:39Z

On Tue, 5 Jan 2010, Felipe Balbi wrote:

> On Tue, Jan 05, 2010 at 03:42:07AM +0100, ext Paul Walmsley wrote:
> > @@ -470,21 +472,51 @@ void omap2_clk_init_cpufreq_table(struct
> > cpufreq_frequency_table **table)
> > if (prcm->dpll_speed == prcm->xtal_speed)
> > continue;
> >
> > + tbl_sz++;
> > + }
> > +
> > + /*
> > + * XXX Ensure that we're doing what CPUFreq expects for this error
> > + * case and the following one
> > + */
> > + if (tbl_sz == 0) {
> > + pr_warning("%s: no matching entries in rate_table\n",
> > + __func__);
> > + goto ocict_exit;
>
> you only use this ocict_exit here, so how about only return instead of a goto
> to a return ?

It's used twice. But your latter point is a good one. I will change
that.

- Paul