From: Felipe Balbi <felipe.balbi@nokia.com>
To: ext Paul Walmsley <paul@pwsan.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>
Subject: Re: [PATCH 3/4] OMAP2 clock: dynamically allocate CPUFreq frequency table
Date: Tue, 5 Jan 2010 12:42:10 +0200 [thread overview]
Message-ID: <20100105104210.GA11291@nokia.com> (raw)
In-Reply-To: <20100105024206.16275.58063.stgit@localhost.localdomain>
Hi,
On Tue, Jan 05, 2010 at 03:42:07AM +0100, ext Paul Walmsley wrote:
>@@ -470,21 +472,51 @@ void omap2_clk_init_cpufreq_table(struct cpufreq_frequency_table **table)
> if (prcm->dpll_speed == prcm->xtal_speed)
> continue;
>
>+ tbl_sz++;
>+ }
>+
>+ /*
>+ * XXX Ensure that we're doing what CPUFreq expects for this error
>+ * case and the following one
>+ */
>+ if (tbl_sz == 0) {
>+ pr_warning("%s: no matching entries in rate_table\n",
>+ __func__);
>+ goto ocict_exit;
you only use this ocict_exit here, so how about only return instead of a
goto to a return ?
--
balbi
next prev parent reply other threads:[~2010-01-05 10:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 2:42 [PATCH 0/4] OMAP2xxx clock/CPUFreq: fix compilation errors; clean up Paul Walmsley
2010-01-05 2:42 ` [PATCH 1/4] OMAP2: clock: clk2xxx.c doesn't compile if CPUFREQ is enabled Paul Walmsley
2010-01-05 10:51 ` Felipe Balbi
2010-01-05 16:03 ` Paul Walmsley
2010-01-05 2:42 ` [PATCH 2/4] OMAP2xxx OPP: clean up comments in OPP data Paul Walmsley
2010-01-05 2:42 ` [PATCH 3/4] OMAP2 clock: dynamically allocate CPUFreq frequency table Paul Walmsley
2010-01-05 10:42 ` Felipe Balbi [this message]
2010-01-05 16:22 ` Paul Walmsley
2010-01-05 2:42 ` [PATCH 4/4] OMAP clock/CPUFreq: avoid leaking the " Paul Walmsley
2010-01-05 10:46 ` Felipe Balbi
2010-01-05 15:58 ` Paul Walmsley
2010-01-19 19:26 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100105104210.GA11291@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox