From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH v3 1/2] USB: Add empty functions in otg.h Date: Tue, 5 Jan 2010 11:53:07 -0600 Message-ID: <20100105175307.GA27177@lixom.net> References: <1262681218-6875-1-git-send-email-x0082077@ti.com> <20100105105450.GD11291@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from lixom.net ([66.141.50.11]:46134 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754757Ab0AERqZ (ORCPT ); Tue, 5 Jan 2010 12:46:25 -0500 Content-Disposition: inline In-Reply-To: <20100105105450.GD11291@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Felipe Balbi Cc: ext Maulik Mankad , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" , Tony Lindgren , Greg Kroah-Hartman , Sergei Shtylyov , "Gupta, Ajay Kumar" On Tue, Jan 05, 2010 at 12:54:50PM +0200, Felipe Balbi wrote: > On Tue, Jan 05, 2010 at 09:46:58AM +0100, ext Maulik Mankad wrote: >> USB : Add empty functions in otg.h >> >> Add empty functions for usb_nop_xceiv_register() >> and usb_nop_xceiv_unregister() in otg.h so that >> these functions can be called even when >> CONFIG_NOP_USB_XCEIV is not enabled. >> >> It allows to remove ifdef's from board file. >> >> Signed-off-by: Maulik Mankad >> Cc: Tony Lindgren >> Cc: Felipe Balbi > > Signed-off-by: Felipe Balbi > > Now this patch looks ok. Don't you mean Acked-by? Anyway, also: Acked-by: Olof Johansson -Olof