public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-omap@vger.kernel.org,
	Mika Westerberg <ext-mika.1.westerberg@nokia.com>,
	Kevin Hilman <khilman@deeprootsystems.com>
Subject: Re: [PATCH] omap: make serial_in_override() address the right uart port
Date: Tue, 5 Jan 2010 10:16:31 -0800	[thread overview]
Message-ID: <20100105181631.GE12378@atomide.com> (raw)
In-Reply-To: <20100105180905.GF29059@shisha.kicks-ass.net>

* Alexander Shishkin <virtuoso@slind.org> [100105 10:08]:
> On Tue, Jan 05, 2010 at 10:03:01 -0800, Tony Lindgren wrote:
> > * Alexander Shishkin <virtuoso@slind.org> [100105 08:56]:
> > > Commit f62349ee9788b1d94c55eb6c291d74a1f69bdd9e makes it possible to
> > > have some other than first uart port as ttyS0, which breaks the workaround
> > > serial_in_override() function which will try to address the first uart
> > > port (for ttyS0) and not the one that was initialized.
> > 
> > Nothing wrong with this patch.. But so we're back to having the ports move
> > around again? That sucks. I wonder if we can initialize dummy 8250 ports
> > somehow to keep the order correct to avoid confusion.
> 
> It doesn't seem like any solution to this problem will suck less than the
> current one, but let's think about it. My patch only addresses the issue I'm
> having with the current solution.

Agreed, we need to fix the problem first.

Regards,

Tony

  reply	other threads:[~2010-01-05 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 16:57 [PATCH] omap: make serial_in_override() address the right uart port Alexander Shishkin
2010-01-05 18:03 ` Tony Lindgren
2010-01-05 18:09   ` Alexander Shishkin
2010-01-05 18:16     ` Tony Lindgren [this message]
2010-01-07  0:05 ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100105181631.GE12378@atomide.com \
    --to=tony@atomide.com \
    --cc=ext-mika.1.westerberg@nokia.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox