public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org, Roel Kluin <roel.kluin@gmail.com>
Subject: [PATCH 03/12] omap: &&/|| confusion in iommu_put()
Date: Wed, 06 Jan 2010 16:19:11 -0800	[thread overview]
Message-ID: <20100107001911.21352.93513.stgit@baageli.muru.com> (raw)
In-Reply-To: <20100107001728.21352.38471.stgit@baageli.muru.com>

From: Roel Kluin <roel.kluin@gmail.com>

obj can't be both NULL and be an error pointer.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/plat-omap/iommu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
index c0ff1e3..463d638 100644
--- a/arch/arm/plat-omap/iommu.c
+++ b/arch/arm/plat-omap/iommu.c
@@ -827,7 +827,7 @@ EXPORT_SYMBOL_GPL(iommu_get);
  **/
 void iommu_put(struct iommu *obj)
 {
-	if (!obj && IS_ERR(obj))
+	if (!obj || IS_ERR(obj))
 		return;
 
 	mutex_lock(&obj->iommu_lock);


  parent reply	other threads:[~2010-01-07  0:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-07  0:18 [PATCH 00/12] Omap fixes for 2.6.33-rc3 Tony Lindgren
2010-01-07  0:18 ` [PATCH 01/12] omap: McBSP: Fix possible port lockout Tony Lindgren
2010-01-08 17:14   ` Sergei Shtylyov
2010-01-10 19:55     ` Janusz Krzysztofik
2010-01-07  0:18 ` [PATCH 02/12] omap: gpio: Simultaneously requested rising and falling edge Tony Lindgren
2010-01-07  0:19 ` Tony Lindgren [this message]
2010-01-07  0:19 ` [PATCH 04/12] omap: Remove uninitialized warning for gpio.c Tony Lindgren
2010-01-07  0:19 ` [PATCH 05/12] omap1: Add 7xx clocks and pin muxes for SPI Tony Lindgren
2010-01-07  9:46   ` Grazvydas Ignotas
2010-01-07 19:15     ` Tony Lindgren
2010-01-09 18:02       ` Cory Maccarrone
2010-01-07  0:19 ` [PATCH 06/12] omap1: Fix compile for omap1_bl.c Tony Lindgren
2010-01-07  0:19 ` [PATCH 07/12] omap2/3: make serial_in_override() address the right uart port Tony Lindgren
2010-01-07  0:20 ` [PATCH 08/12] omap2/3: ZOOM: Correcting key mapping for few keys Tony Lindgren
2010-01-07  0:20 ` [PATCH 09/12] omap3: add missing parentheses Tony Lindgren
2010-01-07  0:20 ` [PATCH 10/12] " Tony Lindgren
2010-01-07  0:20 ` [PATCH 11/12] omap3: Fix booting if package is uninitialized Tony Lindgren
2010-01-07  0:20 ` [PATCH 12/12] omap3: EVM: Choose OMAP_PACKAGE_CBB Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100107001911.21352.93513.stgit@baageli.muru.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox