Re: [PATCH] OMAP2: add USB platform data and initialization for Nokia N800 and N810

Luke-Jr
2009-12-29T08:47:08Z

On Tuesday 29 December 2009 02:29:22 am Kalle Valo wrote:
> "Luke-Jr" <luke@dashjr.org> writes:
> > Tested on Nokia N810 in Linux-OMAP tree. Mainline is not bootable yet.
>
> What's the problem in mainline? I haven't tested n8x0 for months :(

Lack of platform support, as far as I know.
Until we have cbus, there's no way to get the LCD powered...

> > --- a/arch/arm/mach-omap2/Kconfig
> > +++ b/arch/arm/mach-omap2/Kconfig
> > @@ -117,6 +117,11 @@ config MACH_NOKIA_N8X0
> > select MACH_NOKIA_N810
> > select MACH_NOKIA_N810_WIMAX
> >
> > +config MACH_NOKIA_N8X0_USB
> > + bool
> > + depends on MACH_NOKIA_N8X0 && MACH_OMAP2_TUSB6010
> > + default y
> > +
>
> Is is really needed to add new kconfig variable? Can't we just use
> MACH_OMAP2_TUSB6010 in code?
>
> I think a separate file is not needed, it's not that much code. I
> recommend to just adding it directly to board-n8x0.c. It's simple and
> easier for everyone.

Seemed simpler to manage in a separate file, though not as necessary as the
LCD stuff (which I also have a patch against mainline for, but it needs
tahvo...)

> > --- a/arch/arm/mach-omap2/board-n8x0.c
> > +++ b/arch/arm/mach-omap2/board-n8x0.c
> > @@ -109,8 +109,16 @@ static void __init n8x0_init_irq(void)
> > omap_gpio_init();
> > }
> >
> > +#ifdef CONFIG_MACH_NOKIA_N8X0_LCD
> > +extern void n8x0_usb_init(void);
> > +#else
> > +static inline void n8x0_usb_init (void) {}
> > +#endif
>
> CONFIG_MACH_NOKIA_N8X0_LCD does not look right here.

Heh, looks like my isolate-and-merge-to-mainline got messed up there.
Of course it should be CONFIG_MACH_NOKIA_N8X0_USB :)

Also, scripts/checkpatch.pl gave me a warning about the extern in a .c file,
but I couldn't figure out where else it could reasonably go. Any ideas? :/

Luke