Re: [PATCH 1/6] DSPBRIDGE: replace IO_ADDRESS with ioremap

Tony Lindgren
2010-01-11T22:32:26Z

* Omar Ramirez Luna <omar.ramirez@ti.com> [100111 12:02]:
> Use ioremap() instead of using IO_ADDRESS macro to make it generic.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
> CC: Nishant Menon <nm@ti.com>
> CC: Hiroshi Doyu <Hiroshi.DOYU@nokia.com>
> CC: Ameya Palande <ameya.palande@nokia.com>
> CC: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> drivers/dsp/bridge/services/clk.c | 15 +++++++++------
> 1 files changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/dsp/bridge/services/clk.c b/drivers/dsp/bridge/services/clk.c
> index d1c68fc..116e10e 100644
> --- a/drivers/dsp/bridge/services/clk.c
> +++ b/drivers/dsp/bridge/services/clk.c
> @@ -54,10 +54,9 @@
>
> typedef volatile unsigned long REG_UWORD32;
>
> -#define SSI_Base 0x48058000
> -
> -#define SSI_BASE IO_ADDRESS(SSI_Base)
> -
> +#define OMAP_SSI_OFFSET 0x58000
> +#define OMAP_SSI_SIZE 0x1000
> +#define OMAP_SSI_SYSCONFIG_OFFSET 0x10
>
> struct SERVICES_Clk_t {
> struct clk *clk_handle;
> @@ -355,7 +354,9 @@ s32 CLK_Get_UseCnt(IN enum SERVICES_ClkId clk_id)
> void SSI_Clk_Prepare(bool FLAG)
> {
> u32 ssi_sysconfig;
> - ssi_sysconfig = __raw_readl((SSI_BASE) + 0x10);
> + void __iomem *ssi_base;
> +
> + ssi_base = ioremap(L4_34XX_BASE + OMAP_SSI_OFFSET, OMAP_SSI_SIZE);

Please check the results from ioremap. Currently we're using static mapping,
but that may not always be the case in the future.

Regards,

Tony