From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: linux-omap@vger.kernel.org, lrg@slimlogic.co.uk
Subject: Re: [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms
Date: Fri, 15 Jan 2010 11:12:59 +0000 [thread overview]
Message-ID: <20100115111259.GC28625@sirena.org.uk> (raw)
In-Reply-To: <1263287625-10094-1-git-send-email-anuj.aggarwal@ti.com>
On Tue, Jan 12, 2010 at 02:43:45PM +0530, Anuj Aggarwal wrote:
> Anuj Aggarwal (4):
> Regulator: OMAP: Creating TWL4030 file having supplies & init data
I'd expect to see the header file here have ifdef guards and also
include the headers it depends on (linux/regulator/machine.h at least)
but both of those could be fixed up later. Otherwise it all looks OK
from a regulator point of view
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-01-15 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 9:13 [PATCHv2 0/4] Regulator: OMAP: Removing common code for TWL4030 from OMAP3- board-evms Anuj Aggarwal
2010-01-13 16:55 ` Aggarwal, Anuj
2010-01-14 19:47 ` Liam Girdwood
2010-01-15 11:12 ` Mark Brown [this message]
2010-01-29 13:07 ` Aggarwal, Anuj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100115111259.GC28625@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox