From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 1/4] omap: Clean the serial port defines Date: Sat, 16 Jan 2010 11:25:38 -0800 Message-ID: <20100116192538.GK10318@atomide.com> References: <20100116013205.10065.95921.stgit@baageli.muru.com> <20100116013510.10065.59461.stgit@baageli.muru.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:53923 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab0APTZd (ORCPT ); Sat, 16 Jan 2010 14:25:33 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" * Shilimkar, Santosh [100115 23:46]: > Thanks for the nice cleanup. Thanks for testing :) > > > --- a/arch/arm/plat-omap/include/plat/common.h > > +++ b/arch/arm/plat-omap/include/plat/common.h > > @@ -47,6 +47,10 @@ struct omap_globals { > > void __iomem *prm; /* Power and Reset Management */ > > void __iomem *cm; /* Clock Management */ > > void __iomem *cm2; > > + unsigned long uart1_phys; > > + unsigned long uart2_phys; > > + unsigned long uart3_phys; > > + unsigned long uart4_phys; > Considering they are register base address, can > these be declared as "void __iomem" instead of "unsigned long" These are physical addresses instead of virtual addresses. They get ioremapped in mach-omap[12]/serial.c. So they should not be void __iomem * in omap_globals. BTW, we should eventually change everything in omap_globals to be physical addresses. Regards, Tony