From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: ext Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Tony Lindgren <tony@atomide.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits
Date: Mon, 18 Jan 2010 13:13:43 +0200 [thread overview]
Message-ID: <20100118131343.7d763f8c.jhnikula@gmail.com> (raw)
In-Reply-To: <201001181005.12307.peter.ujfalusi@nokia.com>
On Mon, 18 Jan 2010 10:05:12 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > What about introducing this simplification in a separate followup patch,
> > quoting your rationale in its changelog? I can try to prepare one if you
> > agree.
>
> I think it is OK to have a followup patch addressing these.
> Just mention in a comment, that you are writing the cached value back to the
> register, which does not have these status flags set, thus clearing the reason
> in McBSP.
>
> Jarkko: What do you think?
>
I agree, follow-up patch sound cleaner and safer than modifying the
patch 4.
--
Jarkko
next prev parent reply other threads:[~2010-01-18 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 15:58 [PATCH v9 0/4] OMAP: McBSP: Use register cache Janusz Krzysztofik
2010-01-14 16:03 ` [PATCH v9 1/4] OMAP: McBSP: Use macros for all register read/write operations Janusz Krzysztofik
2010-01-14 16:07 ` [PATCH v9 2/4] OMAP: McBSP: Modify macros/functions API for easy cache access Janusz Krzysztofik
2010-01-14 16:11 ` [PATCH v9 3/4] OMAP: McBSP: Introduce caching in register write operations Janusz Krzysztofik
2010-01-14 16:13 ` [PATCH v9 4/4] OMAP: McBSP: Use cache when modifying individual register bits Janusz Krzysztofik
2010-01-15 9:11 ` Peter Ujfalusi
2010-01-15 16:43 ` Janusz Krzysztofik
2010-01-18 8:05 ` Peter Ujfalusi
2010-01-18 11:13 ` Jarkko Nikula [this message]
2010-01-15 7:42 ` [PATCH v9 0/4] OMAP: McBSP: Use register cache Jarkko Nikula
2010-01-18 8:07 ` Peter Ujfalusi
2010-02-03 19:49 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118131343.7d763f8c.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox