From: Tony Lindgren <tony@atomide.com>
To: Olof Johansson <olof@lixom.net>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: Enable GPMC clock in gpmc_init
Date: Wed, 20 Jan 2010 17:24:56 -0800 [thread overview]
Message-ID: <20100121012456.GH23467@atomide.com> (raw)
In-Reply-To: <20100120223929.GA10739@lixom.net>
* Olof Johansson <olof@lixom.net> [100120 14:36]:
> Don't assume that gpmc_l3_clk is on, enable it before touching
> configuration registers.
Seems like this is OK to do even though we do not disable it anywhere
currently since we're setting smart idle and L3 autogating also
in gpmc_init. So adding to omap-fixes.
Regards,
Tony
> Signed-off-by: Olof Johansson <olof@lixom.net>
>
>
> diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c
> index e86f5ca..dea72f3 100644
> --- a/arch/arm/mach-omap2/gpmc.c
> +++ b/arch/arm/mach-omap2/gpmc.c
> @@ -534,6 +534,8 @@ void __init gpmc_init(void)
> BUG();
> }
>
> + clk_enable(gpmc_l3_clk);
> +
> l = gpmc_read_reg(GPMC_REVISION);
> printk(KERN_INFO "GPMC revision %d.%d\n", (l >> 4) & 0x0f, l & 0x0f);
> /* Set smart idle mode and automatic L3 clock gating */
next prev parent reply other threads:[~2010-01-21 1:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 22:39 [PATCH] omap: Enable GPMC clock in gpmc_init Olof Johansson
2010-01-21 1:24 ` Tony Lindgren [this message]
2010-01-21 1:25 ` [APPLIED] " Tony Lindgren
2010-01-21 1:32 ` Paul Walmsley
2010-01-21 1:32 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121012456.GH23467@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox