From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: adharmap@codeaurora.org
Cc: Kalle Valo <kalle.valo@iki.fi>,
Linus Walleij <linus.walleij@stericsson.com>,
Jean Pihet <jpihet@mvista.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Tony Lindgren <tony@atomide.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Abhijeet Dharmapurikar <adharmap@quicinc.com>,
linux-kernel@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Andrea Gallo <andrea.gallo@stericsson.com>,
Colin Tuckley <colin.tuckley@arm.com>,
Ingo Molnar <mingo@elte.hu>,
linux-omap@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
Philby John <pjohn@in.mvista.com>,
linux-arm-kernel@lists.infradead.org,
Alessandro Rubini <rubini@unipv.it>
Subject: Re: [PATCH 1/5] gic: prevent gic from crossing NR_IRQ
Date: Wed, 27 Jan 2010 22:43:09 +0000 [thread overview]
Message-ID: <20100127224309.GD29665@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1264620749-24527-2-git-send-email-adharmap@codeaurora.org>
On Wed, Jan 27, 2010 at 11:32:25AM -0800, adharmap@codeaurora.org wrote:
> From: Abhijeet Dharmapurikar <adharmap@quicinc.com>
>
> The gic code tries to initialize interrupts beyond NR_IRQ. Prevent
> code from doing that.
NAK. This is completely the wrong approach.
/*
* Find out how many interrupts are supported.
*/
max_irq = readl(base + GIC_DIST_CTR) & 0x1f;
max_irq = (max_irq + 1) * 32;
/*
* The GIC only supports up to 1020 interrupt sources.
* Limit this to either the architected maximum, or the
* platform maximum.
*/
if (max_irq > max(1020, NR_IRQS))
max_irq = max(1020, NR_IRQS);
...
for (i = irq_start; i < gic_data[gic_nr].irq_offset + max_irq; i++) {
This function is broken if irq_start != 0, and needs fixing - max_irq
needs to be limited to the _minimum_ of 1020 or NR_IRQS - irq_start.
next prev parent reply other threads:[~2010-01-27 22:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 19:32 [PATCH 0/5] Arm Gic Changes adharmap
2010-01-27 19:32 ` [PATCH 1/5] gic: prevent gic from crossing NR_IRQ adharmap
2010-01-27 22:43 ` Russell King - ARM Linux [this message]
2010-01-28 13:19 ` Catalin Marinas
2010-01-27 19:32 ` [PATCH 2/5] gic: add callback for mask_ack adharmap
2010-01-27 19:32 ` [PATCH 3/5] gic: Add set_type callback adharmap
2010-01-27 23:09 ` Russell King - ARM Linux
2010-01-27 23:18 ` Russell King - ARM Linux
2010-01-28 1:43 ` Abhijeet Dharmapurikar
2010-05-07 10:56 ` Linus Walleij
2010-01-27 19:32 ` [PATCH 4/5] gic: dont disable INT in ack callback adharmap
2010-01-27 19:32 ` [RFC PATCH 5/5] gic: initialize interrupts as per argument adharmap
2010-01-27 23:29 ` Russell King - ARM Linux
2010-01-28 0:39 ` [PATCH 0/5] Arm Gic Changes Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127224309.GD29665@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=adharmap@codeaurora.org \
--cc=adharmap@quicinc.com \
--cc=andrea.gallo@stericsson.com \
--cc=catalin.marinas@arm.com \
--cc=colin.tuckley@arm.com \
--cc=jpihet@mvista.com \
--cc=kalle.valo@iki.fi \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjohn@in.mvista.com \
--cc=rubini@unipv.it \
--cc=santosh.shilimkar@ti.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tony@atomide.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).