From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: adharmap@codeaurora.org
Cc: Kalle Valo <kalle.valo@iki.fi>,
Linus Walleij <linus.walleij@stericsson.com>,
Jean Pihet <jpihet@mvista.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>,
Tony Lindgren <tony@atomide.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Abhijeet Dharmapurikar <adharmap@quicinc.com>,
linux-kernel@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Andrea Gallo <andrea.gallo@stericsson.com>,
Colin Tuckley <colin.tuckley@arm.com>,
Ingo Molnar <mingo@elte.hu>,
linux-omap@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
Philby John <pjohn@in.mvista.com>,
linux-arm-kernel@lists.infradead.org,
Alessandro Rubini <rubini@unipv.it>
Subject: Re: [PATCH 3/5] gic: Add set_type callback
Date: Wed, 27 Jan 2010 23:18:32 +0000 [thread overview]
Message-ID: <20100127231832.GF29665@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1264620749-24527-4-git-send-email-adharmap@codeaurora.org>
On Wed, Jan 27, 2010 at 11:32:27AM -0800, adharmap@codeaurora.org wrote:
> + if (flow_type & (IRQ_TYPE_EDGE_RISING|IRQ_TYPE_EDGE_FALLING)) {
> + reg_value |= (2<<bit_index);
> + writel(reg_value, gic_dist_base(irq) + GIC_DIST_CONFIG
> + + register_index);
> + __set_irq_handler_unlocked(irq, handle_edge_irq);
> + }
> +
> + if (flow_type & (IRQ_TYPE_LEVEL_HIGH|IRQ_TYPE_LEVEL_LOW)) {
This is actually where things start to get rather sticky - because
there may well be on-chip inverters between the GIC and external
peripherals.
Since the GIC can only sense one edge or one level depending on the
hardware setup, it seems wrong to allow the configuration of both
high and low levels, and both edges.
next prev parent reply other threads:[~2010-01-27 23:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 19:32 [PATCH 0/5] Arm Gic Changes adharmap
2010-01-27 19:32 ` [PATCH 1/5] gic: prevent gic from crossing NR_IRQ adharmap
2010-01-27 22:43 ` Russell King - ARM Linux
2010-01-28 13:19 ` Catalin Marinas
2010-01-27 19:32 ` [PATCH 2/5] gic: add callback for mask_ack adharmap
2010-01-27 19:32 ` [PATCH 3/5] gic: Add set_type callback adharmap
2010-01-27 23:09 ` Russell King - ARM Linux
2010-01-27 23:18 ` Russell King - ARM Linux [this message]
2010-01-28 1:43 ` Abhijeet Dharmapurikar
2010-05-07 10:56 ` Linus Walleij
2010-01-27 19:32 ` [PATCH 4/5] gic: dont disable INT in ack callback adharmap
2010-01-27 19:32 ` [RFC PATCH 5/5] gic: initialize interrupts as per argument adharmap
2010-01-27 23:29 ` Russell King - ARM Linux
2010-01-28 0:39 ` [PATCH 0/5] Arm Gic Changes Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127231832.GF29665@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=adharmap@codeaurora.org \
--cc=adharmap@quicinc.com \
--cc=andrea.gallo@stericsson.com \
--cc=catalin.marinas@arm.com \
--cc=colin.tuckley@arm.com \
--cc=jpihet@mvista.com \
--cc=kalle.valo@iki.fi \
--cc=khilman@deeprootsystems.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjohn@in.mvista.com \
--cc=rubini@unipv.it \
--cc=santosh.shilimkar@ti.com \
--cc=srinidhi.kasagar@stericsson.com \
--cc=tony@atomide.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).