From: Ladislav Michl <Ladislav.Michl@seznam.cz>
To: Vimal Singh <vimal.newwork@gmail.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v3 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init
Date: Mon, 8 Feb 2010 16:32:10 +0100 [thread overview]
Message-ID: <20100208153210.GA12307@localhost.localdomain> (raw)
In-Reply-To: <ce9ab5791002080508t33283d20k7f08f1dbf42d2718@mail.gmail.com>
On Mon, Feb 08, 2010 at 06:38:57PM +0530, Vimal Singh wrote:
> In this version: (as per comments recieved for 2nd version)
> - remove 'omap_set_vpp' function
> - set 'set_vpp' to null
Ah, I'm sorry for not being quite exact. "leave set_vpp set to NULL" means
there is no need to asign anything to that structure member, because BSS is
zeroed (set to NULL) anyway. Something like this:
static struct physmap_flash_data sdp_nor_data = {
.width = 2,
};
Yes, this is a nitpick only...
next prev parent reply other threads:[~2010-02-08 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-08 13:08 [PATCH v3 2/3] OMAP: SDP: Introducing 'board-sdp-flash.c' for flash init Vimal Singh
2010-02-08 15:32 ` Ladislav Michl [this message]
2010-02-08 14:47 ` Vimal Singh
-- strict thread matches above, loose matches on Subject: below --
2010-02-08 14:50 Vimal Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100208153210.GA12307@localhost.localdomain \
--to=ladislav.michl@seznam.cz \
--cc=ladis@linux-mips.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox