From: Tony Lindgren <tony@atomide.com>
To: "Pandita, Vikram" <vikram.pandita@ti.com>
Cc: "Premi, Sanjeev" <premi@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: omap3evm: Doesn't boot at 4fa42e46
Date: Wed, 10 Feb 2010 15:24:43 -0800 [thread overview]
Message-ID: <20100210232442.GX21755@atomide.com> (raw)
In-Reply-To: <FCCFB4CDC6E5564B9182F639FC3560870300C4D03F@dbde02.ent.ti.com>
* Pandita, Vikram <vikram.pandita@ti.com> [100210 14:56]:
<snip>
> >> > The kernel panics during I2C init in function omap3_evm_i2c_init()
> >> > during this call:
> >> >
> >> > omap_register_i2c_bus(2, 400, NULL, 0);
>
> I see that Zoom2/3 also don't boot up and given that DEBUG_LL does not work for these boards,
> its very difficult to narrow down the problem.
>
> After around 2 hours of narrowing down, this is what solves the issue probably:
> m0_entry seems to be null, causing strcmp() to crash.
>
> Patch: (will not apply as TABS are not there :) )
> diff --git a/arch/arm/mach-omap2/mux.c b/arch/arm/mach-omap2/mux.c
> index 986077f..d5a03f8 100644
> --- a/arch/arm/mach-omap2/mux.c
> +++ b/arch/arm/mach-omap2/mux.c
> @@ -435,7 +435,7 @@ int __init omap_mux_init_signal(char *muxname, int val)
> char *m0_entry = m->muxnames[0];
> int i;
>
> - if (m0_name && strcmp(m0_name, m0_entry))
> + if (m0_name && m0_entry && strcmp(m0_name, m0_entry))
> continue;
>
> for (i = 0; i < OMAP_MUX_NR_MODES; i++) {
>
>
Hmm is this only with CONFIG_OMAP_MUX and only on 3630?
In for-next we don't have yet the recent mux fix commit
9ecef433204f9b06550dd45cf84f14706f8fe4f0. Can you make sure
you have that applied and see if that solves the problem?
To me it seems that m0_entry should never be NULL after mux
init as that's the signal register name. The 3630 entries should
get populated by omap_mux_init_list.
If omap36xx_cbp_subset is missing some of the 3630 only entries
added by commit 9ecef433204f9b06550dd45cf84f14706f8fe4f0 into
omap3_muxmodes, then that would explain why m0_entry would
be NULL..
Anyways, as I don't have a 3630 here I'm just guessing. Until
you get the DEBUG_LL working on zoom3, you can just increase
the CONFIG_LOG_BUF_SHIFT to something large enough and printk
m0_name and m0_entry without doing anything with them. Then
after the boot you can take a look at dmesg and see if it
provides any clues.
Regards,
Tony
next prev parent reply other threads:[~2010-02-10 23:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-09 15:31 omap3evm: Doesn't boot at 4fa42e46 Premi, Sanjeev
2010-02-09 16:03 ` Premi, Sanjeev
2010-02-10 17:10 ` Premi, Sanjeev
2010-02-10 17:34 ` Tony Lindgren
2010-02-10 22:58 ` Pandita, Vikram
2010-02-10 23:24 ` Tony Lindgren [this message]
2010-02-15 15:26 ` Premi, Sanjeev
2010-02-16 8:51 ` Ranjith Lohithakshan
2010-02-16 9:38 ` Premi, Sanjeev
2010-02-16 18:27 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210232442.GX21755@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox