Re: [PATCH v2 08/13] OMAP3/4 clock: split into per-chip family files

Paul Walmsley
2010-02-16T21:54:54Z

On Tue, 16 Feb 2010, Tony Lindgren wrote:

> * Paul Walmsley <paul@pwsan.com> [100215 16:56]:
> >
> > clock34xx_data.c now contains data for the OMAP34xx family, the
> > OMAP36xx family, and the OMAP3517 family, so rename it to
> > clock3xxx_data.c. Rename clock34xx.c to clock3xxx.c, and move the
> > chip family-specific clock functions to clock34xx.c, clock36xx.c, or
> > clock3517.c, as appropriate. So now "clock3xxx.*" refers to the OMAP3
> > superset.
> >
> > The main goal here is to prepare to compile chip family-specific clock
> > functions only for kernel builds that target that chip family. To get to
> > that point, we also need to add CONFIG_ARCH_* options for those other
> > chip families; that will be done in a future patch, planned for 2.6.35.
>
> Just to comment on the naming, we should call additional cpu options
> CONFIG_CPU_OMAP3630 etc instead of CONFIG_ARCH_OMAP to avoid confusion.
>
> I thought about renaming CONFIG_ARCH_OMAP2420 and CONFIG_ARCH_OMAP2430
> into CONFIG_CPU_OMAP2420 and CONFIG_CPU_OMAP2430, but as it covers
> a bunch of drivers too I've postponed that to 2.6.35.

Thanks, I've updated the patch description accordingly to reference
CONFIG_CPU_* rather than CONFIG_ARCH_*.

- Paul