From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 0/4 RFC]OMAP:GPIO: Make GPIO an early init device Date: Mon, 15 Feb 2010 09:49:28 -0800 Message-ID: <20100215174928.GC21755@atomide.com> References: <1265981851-11970-1-git-send-email-charu@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:54652 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755332Ab0BORsp (ORCPT ); Mon, 15 Feb 2010 12:48:45 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: "Varadarajan, Charulatha" , linux-omap@vger.kernel.org * Paul Walmsley [100214 17:38]: > On Fri, 12 Feb 2010, Paul Walmsley wrote: > > > On Fri, 12 Feb 2010, Varadarajan, Charulatha wrote: > > > > > OMAP: Convert GPIO into a early driver > > > > The above patch appears to be missing. Could you please re-send? > > This patch was too big for the mailing list, so it's been posted here: > > http://www.pwsan.com/omap/patches/gpio/0002-OMAP-GPIO-split-omap1-and-omap2.patch What, make two almost identical copies of the shared code? No way! Instead, please keep the common code under plat-omap: arch/arm/plat-omap/gpio.c Then implement the processor specific functions: arch/arm/mach-omap1/gpio.c arch/arm/mach-omap2/gpio.c arch/arm/mach-omap2/gpio24xx.c arch/arm/mach-omap2/gpio44xx.c Then have a subsys_initcall in processor specific implementation that sets the function pointers in the common code. Regards, Tony