RE: [PATCH 24/24] omap4: multi-omap: Allow build to work

Shilimkar, Santosh
2010-02-16T16:15:49Z

Anand,
> -----Original Message-----
> From: Gadiyar, Anand
> Sent: Tuesday, February 16, 2010 9:25 PM
> To: Shilimkar, Santosh; tony@atomide.com
> Cc: linux-omap@vger.kernel.org; ben@fluff.org.uk; sameo@linux.intel.com; lrg@slimlogic.co.uk;
> paul@pwsan.com
> Subject: RE: [PATCH] omap4: multi-omap: Allow build to work
>
> Shilimkar, Santosh wrote:
> > The musb support is enable to omap3 platforms. For omap4 only board
> > support is available and the driver still isn't supported.
> > Because of this build with omap3_defconfig used for multi-omap
> > doesn't work on omap4430 sdp.
> >
> > This patch hacks the musb probe to keep the multi-omap build
> > working on omap4430 sdp
> >
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > ---
> > drivers/usb/musb/musb_core.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/musb/musb_core.c
> > b/drivers/usb/musb/musb_core.c
> > index bcce8e8..13b1c4a 100644
> > --- a/drivers/usb/musb/musb_core.c
> > +++ b/drivers/usb/musb/musb_core.c
> > @@ -2124,6 +2124,10 @@ static int __init musb_probe(struct
> > platform_device *pdev)
> > struct resource *iomem;
> > void __iomem *base;
> >
> > + /* FIXME: multi-omap build to work on omap4 */
> > + if (cpu_is_omap44xx())
> > + return 0;
> > +
>
> NAK. I'd prefer that we fix the driver issue correctly.
>
> I would have expected the driver to at least load on OMAP4
> even if it does not work. Could you please describe the
> failure?
>
The probe fails because the register bases aren't mapped
for omap4. This is because Tony has lined-up musb board support
for omap4 but corresponding usb driver patches are not yet lined
up.
> Also, this will need to go through linux-usb.