From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Carmody Subject: Re: [PATCH 2/2] dspbridge: proc: fix a double-free on 2 error paths Date: Wed, 17 Feb 2010 15:12:45 +0200 Message-ID: <20100217131245.GE463@pcarmody-desktop> References: <4B7B3728.60105@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from smtp.nokia.com ([192.100.122.230]:25490 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215Ab0BQNKc (ORCPT ); Wed, 17 Feb 2010 08:10:32 -0500 Content-Disposition: inline In-Reply-To: <4B7B3728.60105@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: ext Omar Ramirez Luna Cc: "Menon, Nishanth" , "linux-omap@vger.kernel.org" On 17/02/10 01:24 +0100, ext Omar Ramirez Luna wrote: > On 2/12/2010 10:26 AM, Phil Carmody wrote: > > From: Phil Carmody > > > > We free in the tail cleanup, so don't free before jumping there. > > > > Signed-off-by: Phil Carmody > > --- > > [...] > > } > > + > > + /* paranoid - must be able to kfree this on remaining error paths */ > > + pProcObject->g_pszLastCoff = NULL; > > + > > do we need this? afaik it should be NULL at this point, because of > kmalloc + memset (which btw should be replaced by kzalloc). I suspected it wasn't. I confess I was a little bit rushed when looking at that. > i.e: > MEM_AllocObject(pProcObject, struct PROC_OBJECT, PROC_SIGNATURE); > -> MEM_Calloc(sizeof(Obj), MEM_NONPAGED); > -> pMem = kmalloc(...) > if (pMem) > memset(pMem, 0, cBytes); i.e. kzalloc(). > > /* Get the default executable for this board... */ > > DEV_GetDevType(hDevObject, (u32 *)&devType); > > pProcObject->uProcessor = devType; > [...] > > Regards, I can resend without, if you like, whatever's simplest for you. Phil