RE: [PATCH 05/24] omap4: Add needed IRQ line into irqs.h

Shilimkar, Santosh
2010-02-17T05:01:26Z

Paul,
> -----Original Message-----
> From: Paul Walmsley [mailto:paul@pwsan.com]
> Sent: Wednesday, February 17, 2010 3:39 AM
> To: Shilimkar, Santosh
> Cc: tony@atomide.com; linux-omap@vger.kernel.org; ben@fluff.org.uk; sameo@linux.intel.com;
> lrg@slimlogic.co.uk
> Subject: Re: [PATCH 05/24] omap4: Add needed IRQ line into irqs.h
>
> Hello Santosh,
>
> On Tue, 16 Feb 2010, Santosh Shilimkar wrote:
>
> > This patch adds DSS, keyboard and ducati irq
> > entries in irqs.h
> >
> > Ones omap4 hwmod is pushed on mainlie, all the
> > irqs lines data would be availabe.
>
> Instead of this patch, why not just replace the current file with the one
> from the OMAP4 autogeneration scripts? I don't see why the IRQ macros
> should depend on hwmod availability, and it would be better to have the
> correct IRQ data appear in one patch, rather than having to review and
> approve several smaller incremental patches over time.
We plan to do this but today the autogenrated file names and one in the
kernel code is different. Autogenrated headers are kept in alignment
with TRM naming as you know.
e.g
--- autogenaretd
#define OMAP44XX_IRQ_MCBSP2 (22 + OMAP44XX_IRQ_GIC_START)

--existing kernel
#define INT_44XX_MCBSP2_IRQ (22 + IRQ_GIC_START)

So instead of touching every driver file and changing it only for name changes ,
what we are doing
1. Created local 44xx_dma.h and 44xx_irq.h mach-omap2 directory
2. All the drivers getting converted in hwmods would use defines from above headers
3. At one point of time all the drivers would use defines from above headers and then
from omap4 point of view there won't be dependency on the irqs.h and dma.h

While this is ongoing, we would like the mainline kernel to have most of the
drivers supported. And Hence such a patch.

> The same reasoning should apply the DMA data also, I'd think.
DMA file will get replaced soon with auto generated since naming
is aligned there.

Regards,
Santosh