Re: [PATCH 08/24] omap4: clocks: Make Uart driver's clock calls OMAP4 compatible

Tony Lindgren
2010-02-16T18:37:47Z

* Santosh Shilimkar <santosh.shilimkar@ti.com> [100216 07:55]:
> From: Abhijit Pagare <abhijitpagare@ti.com>
>
> The uart driver has been adapted for the OMAP4 way of clock calls.
>
> Signed-off-by: Abhijit Pagare <abhijitpagare@ti.com>
> ---
> arch/arm/mach-omap2/serial.c | 24 ++++++++++++++++--------
> 1 files changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
> index b79bc89..97859b0 100644
> --- a/arch/arm/mach-omap2/serial.c
> +++ b/arch/arm/mach-omap2/serial.c
> @@ -257,7 +257,8 @@ static inline void omap_uart_enable_clocks(struct omap_uart_state *uart)
> return;
>
> clk_enable(uart->ick);
> - clk_enable(uart->fck);
> + if (!cpu_is_omap44xx())
> + clk_enable(uart->fck);
> uart->clocked = 1;
> omap_uart_restore_context(uart);
> }
> @@ -272,7 +273,8 @@ static inline void omap_uart_disable_clocks(struct omap_uart_state *uart)
> omap_uart_save_context(uart);
> uart->clocked = 0;
> clk_disable(uart->ick);
> - clk_disable(uart->fck);
> + if (!cpu_is_omap44xx())
> + clk_disable(uart->fck);
> }

As discussed outside the lists, the fck handling for omap4 should be
done with dummy_ck the same way as we're already doing for omap1.

Regards,

Tony