RE: [PATCH 24/24] omap4: multi-omap: Allow build to work

Gadiyar, Anand
2010-02-17T09:12:20Z

Shilimkar, Santosh wrote:
> > From: Gadiyar, Anand
> > Shilimkar, Santosh wrote:
> > > The musb support is enable to omap3 platforms. For omap4 only board
> > > support is available and the driver still isn't supported.
> > > Because of this build with omap3_defconfig used for multi-omap
> > > doesn't work on omap4430 sdp.
> > >
> > > This patch hacks the musb probe to keep the multi-omap build
> > > working on omap4430 sdp
> > >
> > > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > > ---
> > > drivers/usb/musb/musb_core.c | 4 ++++
> > > 1 files changed, 4 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> > > index bcce8e8..13b1c4a 100644
> > > --- a/drivers/usb/musb/musb_core.c
> > > +++ b/drivers/usb/musb/musb_core.c
> > > @@ -2124,6 +2124,10 @@ static int __init musb_probe(struct platform_device *pdev)
> > > struct resource *iomem;
> > > void __iomem *base;
> > >
> > > + /* FIXME: multi-omap build to work on omap4 */
> > > + if (cpu_is_omap44xx())
> > > + return 0;
> > > +
> >
> > NAK. I'd prefer that we fix the driver issue correctly.
> >
> > I would have expected the driver to at least load on OMAP4
> > even if it does not work. Could you please describe the
> > failure?
> >
> The probe fails because the register bases aren't mapped
> for omap4. This is because Tony has lined-up musb board support
> for omap4 but corresponding usb driver patches are not yet lined
> up.

I see the problem now - the platform support is lined up, but the
driver is not queued up yet.

This is easy to fix by removing the call to usb_musb_init from
the 4430sdp board. How about doing this?

- Anand