Re: [PATCH 24/24] omap4: multi-omap: Allow build to work

Tony Lindgren
2010-02-16T18:53:04Z

* Santosh Shilimkar <santosh.shilimkar@ti.com> [100216 07:55]:
> The musb support is enable to omap3 platforms. For omap4 only board
> support is available and the driver still isn't supported.
> Because of this build with omap3_defconfig used for multi-omap
> doesn't work on omap4430 sdp.
>
> This patch hacks the musb probe to keep the multi-omap build
> working on omap4430 sdp
>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> drivers/usb/musb/musb_core.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index bcce8e8..13b1c4a 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2124,6 +2124,10 @@ static int __init musb_probe(struct platform_device *pdev)
> struct resource *iomem;
> void __iomem *base;
>
> + /* FIXME: multi-omap build to work on omap4 */
> + if (cpu_is_omap44xx())
> + return 0;
> +
> iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!iomem || irq == 0)
> return -ENODEV;

Should the comment here be "FIXME: allow multi-omap to boot until
musb is updated for omap4" instead?

Regards,

Tony