From: Jarkko Nikula <jhnikula@gmail.com>
To: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
peter.ujfalusi@nokia.com, broonie@opensource.wolfsonmicro.com,
tony@atomide.com, eduardo.valentin@nokia.com,
ext-eero.nurkkala@nokia.com
Subject: Re: [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature
Date: Thu, 18 Feb 2010 15:06:21 +0200 [thread overview]
Message-ID: <20100218150621.b88387a7.jhnikula@gmail.com> (raw)
In-Reply-To: <1266417960-22787-1-git-send-email-ilkka.koskinen@nokia.com>
On Wed, 17 Feb 2010 16:45:58 +0200
Ilkka Koskinen <ilkka.koskinen@nokia.com> wrote:
> The first patch implements McBSP sidetone feature on OMAP3 while the second one
> provides ALSA interface for using it.
>
Do I have something wrong since I cannot adjust the controls? Both
"McBSP2 Sidetone Channel [0|1]" show 50%.
I used line wrapped diff below.
--
Jarkko
diff --git a/sound/soc/omap/omap3beagle.c b/sound/soc/omap/omap3beagle.c
index d88ad5c..ac4f287 100644
--- a/sound/soc/omap/omap3beagle.c
+++ b/sound/soc/omap/omap3beagle.c
@@ -84,6 +84,11 @@ static int omap3beagle_hw_params(struct
snd_pcm_substream *substream, return 0;
}
+static int omap3beagle_init(struct snd_soc_codec *codec)
+{
+ return omap_mcbsp_st_add_controls(codec, 2);
+}
+
static struct snd_soc_ops omap3beagle_ops = {
.hw_params = omap3beagle_hw_params,
};
@@ -95,6 +100,7 @@ static struct snd_soc_dai_link omap3beagle_dai = {
.cpu_dai = &omap_mcbsp_dai[0],
.codec_dai = &twl4030_dai[TWL4030_DAI_HIFI],
.ops = &omap3beagle_ops,
+ .init = omap3beagle_init,
};
/* Audio machine driver */
next prev parent reply other threads:[~2010-02-18 13:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 14:45 [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature Ilkka Koskinen
2010-02-17 14:45 ` [PATCHv2 1/2] " Ilkka Koskinen
2010-02-17 14:46 ` [PATCHv2 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone Ilkka Koskinen
2010-02-18 8:14 ` Peter Ujfalusi
2010-02-18 8:49 ` ilkka.koskinen
2010-02-18 0:25 ` [PATCHv2 1/2] McBSP: OMAP3: Add sidetone feature Tony Lindgren
2010-02-18 10:58 ` Ilkka Koskinen
2010-02-18 11:01 ` Mark Brown
2010-02-18 17:16 ` Tony Lindgren
2010-02-18 17:14 ` Tony Lindgren
2010-02-18 13:06 ` Jarkko Nikula [this message]
2010-02-18 14:04 ` [PATCHv2 0/2] " Peter Ujfalusi
-- strict thread matches above, loose matches on Subject: below --
2010-02-18 12:37 Ilkka Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218150621.b88387a7.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=ext-eero.nurkkala@nokia.com \
--cc=ilkka.koskinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox