From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature Date: Thu, 18 Feb 2010 15:24:13 +0200 Message-ID: <20100218152413.11d0189a.jhnikula@gmail.com> References: <1266496635-31347-1-git-send-email-ilkka.koskinen@nokia.com> <1266496635-31347-2-git-send-email-ilkka.koskinen@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from ey-out-2122.google.com ([74.125.78.24]:49323 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109Ab0BRNS4 (ORCPT ); Thu, 18 Feb 2010 08:18:56 -0500 Received: by ey-out-2122.google.com with SMTP id d26so2044524eyd.19 for ; Thu, 18 Feb 2010 05:18:54 -0800 (PST) In-Reply-To: <1266496635-31347-2-git-send-email-ilkka.koskinen@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Ilkka Koskinen Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, peter.ujfalusi@nokia.com, broonie@opensource.wolfsonmicro.com, tony@atomide.com, eduardo.valentin@nokia.com, ext-Eero.Nurkkala@nokia.com On Thu, 18 Feb 2010 14:37:14 +0200 Ilkka Koskinen wrote: > static inline void __devexit omap34xx_device_exit(struct omap_mcbsp *mcbsp) > { > - if (cpu_is_omap34xx()) > + if (cpu_is_omap34xx()) { > omap_additional_remove(mcbsp->dev); > + > + if (mcbsp->id == 2 || mcbsp->id == 3) > + omap_st_remove(mcbsp); > + } > } Are you sure about these ids? Same comment to the patch 2 as well. Worth to check. -- Jarkko