From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
"Koskinen Ilkka (Nokia-D/Tampere)" <ilkka.koskinen@nokia.com>
Subject: Re: [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature
Date: Thu, 18 Feb 2010 15:56:03 +0200 [thread overview]
Message-ID: <201002181556.03245.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20100218152413.11d0189a.jhnikula@gmail.com>
Hello,
On Thursday 18 February 2010 15:24:13 ext Jarkko Nikula wrote:
> On Thu, 18 Feb 2010 14:37:14 +0200
>
> Ilkka Koskinen <ilkka.koskinen@nokia.com> wrote:
> > static inline void __devexit omap34xx_device_exit(struct omap_mcbsp
> > *mcbsp) {
> >
> > - if (cpu_is_omap34xx())
> > + if (cpu_is_omap34xx()) {
> >
> > omap_additional_remove(mcbsp->dev);
> >
> > +
> > + if (mcbsp->id == 2 || mcbsp->id == 3)
> > + omap_st_remove(mcbsp);
> > + }
> >
> > }
>
> Are you sure about these ids? Same comment to the patch 2 as well.
> Worth to check.
They are correct.
mcbsp->id is 1 based (1 -> McBSP1, 2 -> McBSP2, etc)
While the exported functions expect the id to
be 0 based (0 -> McBSP1, 1 -> McBSP2, etc)
But, yes it is confusing at times...
--
Péter
next prev parent reply other threads:[~2010-02-18 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 12:37 [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature Ilkka Koskinen
2010-02-18 12:37 ` [PATCHv3 1/2] " Ilkka Koskinen
2010-02-18 12:37 ` [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone Ilkka Koskinen
2010-02-18 14:11 ` Peter Ujfalusi
2010-02-18 17:16 ` [alsa-devel] " Ilkka Koskinen
2010-02-18 13:24 ` [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature Jarkko Nikula
2010-02-18 13:56 ` Peter Ujfalusi [this message]
2010-02-18 15:41 ` [alsa-devel] " Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002181556.03245.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=ilkka.koskinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox