RE: [PATCH 1/2] twl6030: regulator: Fix vsel calculations in set/get voltage apis

Nayak, Rajendra
2010-02-19T06:40:11Z

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Thursday, February 18, 2010 5:13 PM
> To: Nayak, Rajendra
> Cc: linux-omap@vger.kernel.org; Liam Girdwood; Samuel Ortiz
> Subject: Re: [PATCH 1/2] twl6030: regulator: Fix vsel
> calculations in set/get voltage apis
>
> On Thu, Feb 18, 2010 at 05:09:53PM +0530, Nayak, Rajendra wrote:
>
> > Mark, I get your point. The table values were derived from
> what the spec
> > suggests, but I agree that its confusing that in theory the formula
> > suggests there could be more selectors than whats present
> in the table.
>
> > I will check if its indeed possible to support all possible
> selectors
> > between say a min/max range. And then have maybe seperate
> kind of tables
> > for twl6030 which only specify min/max range and then use
> the formula to
> > generate the right selector.
>
> Another option if you do need the supported voltage list would be to
> rename the table and have a separate function to do set on
> twl6030 which
> makes the intended usage clear.

Mark, It turns out, all twl6030 regulators can be programmed from
1.0v to 3.3v with 100mV steps. The spec I was referring to was specfic
to the OMAP4 platform I am working on. Hence, it does not prevent
someone using the PMIC on a different platform to have different
voltage requirements.
So I was thinking of removing all the twl6030 tables and just use
the formula to get the selector and make sure they fall in the
allowed range (1.0v to 3.3v).
If that sounds good then I can post a patch for this.

>