* [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic @ 2010-02-18 21:07 Anna, Suman 2010-02-20 18:53 ` Shilimkar, Santosh 0 siblings, 1 reply; 6+ messages in thread From: Anna, Suman @ 2010-02-18 21:07 UTC (permalink / raw) To: linux-omap@vger.kernel.org Cc: Hiroshi.DOYU@nokia.com, Clark, Rob, Kanigeri, Hari, C.A, Subramaniam >From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 From: Suman Anna <s-anna@ti.com> Date: Tue, 26 Jan 2010 16:55:29 -0600 Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic OMAP4 mailbox has a different register set. There is no MAILBOX_SYSSTATUS register. The reset is indicated with the SOFTRESET bit of the MAILBOX_SYSCONFIG register itself. This bit should read 0 for a successful Reset. Also, the SOFTRESET bit occupies bit0 and not bit1 as with previous generations. Signed-off-by: Suman Anna <s-anna@ti.com> --- arch/arm/mach-omap2/mailbox.c | 38 +++++++++++++++++++++++++++----------- 1 files changed, 27 insertions(+), 11 deletions(-) diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c index c970cf6..88e9043 100644 --- a/arch/arm/mach-omap2/mailbox.c +++ b/arch/arm/mach-omap2/mailbox.c @@ -40,6 +40,7 @@ #define AUTOIDLE (1 << 0) #define SOFTRESET (1 << 1) #define SMARTIDLE (2 << 3) +#define OMAP4_SOFTRESET (1 << 0) /* SYSSTATUS: register bit definition */ #define RESETDONE (1 << 0) @@ -99,17 +100,32 @@ static int omap2_mbox_startup(struct omap_mbox *mbox) } clk_enable(mbox_ick_handle); - mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); - timeout = jiffies + msecs_to_jiffies(20); - do { - l = mbox_read_reg(MAILBOX_SYSSTATUS); - if (l & RESETDONE) - break; - } while (!time_after(jiffies, timeout)); - - if (!(l & RESETDONE)) { - pr_err("Can't take mmu out of reset\n"); - return -ENODEV; + if (cpu_is_omap44xx()) { + mbox_write_reg(OMAP4_SOFTRESET, MAILBOX_SYSCONFIG); + timeout = jiffies + msecs_to_jiffies(20); + do { + l = mbox_read_reg(MAILBOX_SYSCONFIG); + if (!(l & OMAP4_SOFTRESET)) + break; + } while (!time_after(jiffies, timeout)); + + if (l & OMAP4_SOFTRESET) { + pr_err("Can't take mailbox out of reset\n"); + return -ENODEV; + } + } else { + mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); + timeout = jiffies + msecs_to_jiffies(20); + do { + l = mbox_read_reg(MAILBOX_SYSSTATUS); + if (l & RESETDONE) + break; + } while (!time_after(jiffies, timeout)); + + if (!(l & RESETDONE)) { + pr_err("Can't take mailbox out of reset\n"); + return -ENODEV; + } } l = mbox_read_reg(MAILBOX_REVISION); -- 1.6.6.2 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic 2010-02-18 21:07 [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic Anna, Suman @ 2010-02-20 18:53 ` Shilimkar, Santosh 2010-02-22 20:07 ` Anna, Suman [not found] ` <7E59F0E987E71F40A4E30590884852DC01725109D4@dnce01.ent.ti.com> 0 siblings, 2 replies; 6+ messages in thread From: Shilimkar, Santosh @ 2010-02-20 18:53 UTC (permalink / raw) To: Anna, Suman, linux-omap@vger.kernel.org Cc: Hiroshi.DOYU@nokia.com, Clark, Rob, Kanigeri, Hari, C.A, Subramaniam > -----Original Message----- > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Anna, > Suman > Sent: Friday, February 19, 2010 2:37 AM > To: linux-omap@vger.kernel.org > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 > From: Suman Anna <s-anna@ti.com> > Date: Tue, 26 Jan 2010 16:55:29 -0600 > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > OMAP4 mailbox has a different register set. There is > no MAILBOX_SYSSTATUS register. The reset is indicated > with the SOFTRESET bit of the MAILBOX_SYSCONFIG register > itself. This bit should read 0 for a successful Reset. > Also, the SOFTRESET bit occupies bit0 and not bit1 as with > previous generations. > > Signed-off-by: Suman Anna <s-anna@ti.com> > --- > arch/arm/mach-omap2/mailbox.c | 38 +++++++++++++++++++++++++++----------- > 1 files changed, 27 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c > index c970cf6..88e9043 100644 > --- a/arch/arm/mach-omap2/mailbox.c > +++ b/arch/arm/mach-omap2/mailbox.c > @@ -40,6 +40,7 @@ > #define AUTOIDLE (1 << 0) > #define SOFTRESET (1 << 1) > #define SMARTIDLE (2 << 3) > +#define OMAP4_SOFTRESET (1 << 0) > > /* SYSSTATUS: register bit definition */ > #define RESETDONE (1 << 0) > @@ -99,17 +100,32 @@ static int omap2_mbox_startup(struct omap_mbox *mbox) > } > clk_enable(mbox_ick_handle); > > - mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); > - timeout = jiffies + msecs_to_jiffies(20); > - do { > - l = mbox_read_reg(MAILBOX_SYSSTATUS); > - if (l & RESETDONE) > - break; > - } while (!time_after(jiffies, timeout)); > - > - if (!(l & RESETDONE)) { > - pr_err("Can't take mmu out of reset\n"); > - return -ENODEV; > + if (cpu_is_omap44xx()) { Not so strong opinion but can we make use of mailbox ip revision instead of cpu_is_xxxx() check. > + mbox_write_reg(OMAP4_SOFTRESET, MAILBOX_SYSCONFIG); > + timeout = jiffies + msecs_to_jiffies(20); > + do { > + l = mbox_read_reg(MAILBOX_SYSCONFIG); > + if (!(l & OMAP4_SOFTRESET)) > + break; > + } while (!time_after(jiffies, timeout)); > + > + if (l & OMAP4_SOFTRESET) { > + pr_err("Can't take mailbox out of reset\n"); > + return -ENODEV; > + } > + } else { > + mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); > + timeout = jiffies + msecs_to_jiffies(20); > + do { > + l = mbox_read_reg(MAILBOX_SYSSTATUS); > + if (l & RESETDONE) > + break; > + } while (!time_after(jiffies, timeout)); > + > + if (!(l & RESETDONE)) { > + pr_err("Can't take mailbox out of reset\n"); > + return -ENODEV; > + } > } > > l = mbox_read_reg(MAILBOX_REVISION); > -- > 1.6.6.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic 2010-02-20 18:53 ` Shilimkar, Santosh @ 2010-02-22 20:07 ` Anna, Suman 2010-02-22 20:15 ` Tony Lindgren [not found] ` <7E59F0E987E71F40A4E30590884852DC01725109D4@dnce01.ent.ti.com> 1 sibling, 1 reply; 6+ messages in thread From: Anna, Suman @ 2010-02-22 20:07 UTC (permalink / raw) To: Shilimkar, Santosh, linux-omap@vger.kernel.org Cc: Hiroshi.DOYU@nokia.com, Clark, Rob, Kanigeri, Hari, C.A, Subramaniam Hi Santosh, > -----Original Message----- > From: Shilimkar, Santosh > Sent: Saturday, February 20, 2010 12:53 PM > To: Anna, Suman; linux-omap@vger.kernel.org > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > -----Original Message----- > > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > owner@vger.kernel.org] On Behalf Of Anna, > > Suman > > Sent: Friday, February 19, 2010 2:37 AM > > To: linux-omap@vger.kernel.org > > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 > > From: Suman Anna <s-anna@ti.com> > > Date: Tue, 26 Jan 2010 16:55:29 -0600 > > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > OMAP4 mailbox has a different register set. There is > > no MAILBOX_SYSSTATUS register. The reset is indicated > > with the SOFTRESET bit of the MAILBOX_SYSCONFIG register > > itself. This bit should read 0 for a successful Reset. > > Also, the SOFTRESET bit occupies bit0 and not bit1 as with > > previous generations. > > > > Signed-off-by: Suman Anna <s-anna@ti.com> > > --- > > arch/arm/mach-omap2/mailbox.c | 38 +++++++++++++++++++++++++++------- > ---- > > 1 files changed, 27 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach- > omap2/mailbox.c > > index c970cf6..88e9043 100644 > > --- a/arch/arm/mach-omap2/mailbox.c > > +++ b/arch/arm/mach-omap2/mailbox.c > > @@ -40,6 +40,7 @@ > > #define AUTOIDLE (1 << 0) > > #define SOFTRESET (1 << 1) > > #define SMARTIDLE (2 << 3) > > +#define OMAP4_SOFTRESET (1 << 0) > > > > /* SYSSTATUS: register bit definition */ > > #define RESETDONE (1 << 0) > > @@ -99,17 +100,32 @@ static int omap2_mbox_startup(struct omap_mbox > *mbox) > > } > > clk_enable(mbox_ick_handle); > > > > - mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); > > - timeout = jiffies + msecs_to_jiffies(20); > > - do { > > - l = mbox_read_reg(MAILBOX_SYSSTATUS); > > - if (l & RESETDONE) > > - break; > > - } while (!time_after(jiffies, timeout)); > > - > > - if (!(l & RESETDONE)) { > > - pr_err("Can't take mmu out of reset\n"); > > - return -ENODEV; > > + if (cpu_is_omap44xx()) { > Not so strong opinion but can we make use of mailbox ip revision instead > of cpu_is_xxxx() check. > This may be a better option in the longer-run, but the current mailbox registers are assigned based on the cpu_is_xxxx() macro, and I have used this readily available macro rather doing a new one. Also, note that the IP revision value is not published in the TRM. Regards Suman ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic 2010-02-22 20:07 ` Anna, Suman @ 2010-02-22 20:15 ` Tony Lindgren 2010-02-22 21:38 ` Tony Lindgren 0 siblings, 1 reply; 6+ messages in thread From: Tony Lindgren @ 2010-02-22 20:15 UTC (permalink / raw) To: Anna, Suman Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Hiroshi.DOYU@nokia.com, Clark, Rob, Kanigeri, Hari, C.A, Subramaniam * Anna, Suman <s-anna@ti.com> [100222 12:04]: > Hi Santosh, > > > -----Original Message----- > > From: Shilimkar, Santosh > > Sent: Saturday, February 20, 2010 12:53 PM > > To: Anna, Suman; linux-omap@vger.kernel.org > > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > > Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > > -----Original Message----- > > > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > > owner@vger.kernel.org] On Behalf Of Anna, > > > Suman > > > Sent: Friday, February 19, 2010 2:37 AM > > > To: linux-omap@vger.kernel.org > > > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > > > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > > > From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 > > > From: Suman Anna <s-anna@ti.com> > > > Date: Tue, 26 Jan 2010 16:55:29 -0600 > > > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > > > OMAP4 mailbox has a different register set. There is > > > no MAILBOX_SYSSTATUS register. The reset is indicated > > > with the SOFTRESET bit of the MAILBOX_SYSCONFIG register > > > itself. This bit should read 0 for a successful Reset. > > > Also, the SOFTRESET bit occupies bit0 and not bit1 as with > > > previous generations. > > > > > > Signed-off-by: Suman Anna <s-anna@ti.com> > > > --- > > > arch/arm/mach-omap2/mailbox.c | 38 +++++++++++++++++++++++++++------- > > ---- > > > 1 files changed, 27 insertions(+), 11 deletions(-) > > > > > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach- > > omap2/mailbox.c > > > index c970cf6..88e9043 100644 > > > --- a/arch/arm/mach-omap2/mailbox.c > > > +++ b/arch/arm/mach-omap2/mailbox.c > > > @@ -40,6 +40,7 @@ > > > #define AUTOIDLE (1 << 0) > > > #define SOFTRESET (1 << 1) > > > #define SMARTIDLE (2 << 3) > > > +#define OMAP4_SOFTRESET (1 << 0) > > > > > > /* SYSSTATUS: register bit definition */ > > > #define RESETDONE (1 << 0) > > > @@ -99,17 +100,32 @@ static int omap2_mbox_startup(struct omap_mbox > > *mbox) > > > } > > > clk_enable(mbox_ick_handle); > > > > > > - mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); > > > - timeout = jiffies + msecs_to_jiffies(20); > > > - do { > > > - l = mbox_read_reg(MAILBOX_SYSSTATUS); > > > - if (l & RESETDONE) > > > - break; > > > - } while (!time_after(jiffies, timeout)); > > > - > > > - if (!(l & RESETDONE)) { > > > - pr_err("Can't take mmu out of reset\n"); > > > - return -ENODEV; > > > + if (cpu_is_omap44xx()) { > > Not so strong opinion but can we make use of mailbox ip revision instead > > of cpu_is_xxxx() check. > > > > This may be a better option in the longer-run, but the current mailbox registers are assigned based on the cpu_is_xxxx() macro, and I have used this readily available macro rather doing a new one. Also, note that the IP revision value is not published in the TRM. In the long run the most flexible option is to check the revision for each device during init. Anyways, sounds like that's another patch on top of these patches. Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic 2010-02-22 20:15 ` Tony Lindgren @ 2010-02-22 21:38 ` Tony Lindgren 0 siblings, 0 replies; 6+ messages in thread From: Tony Lindgren @ 2010-02-22 21:38 UTC (permalink / raw) To: Anna, Suman Cc: Shilimkar, Santosh, linux-omap@vger.kernel.org, Hiroshi.DOYU@nokia.com, Clark, Rob, Kanigeri, Hari, C.A, Subramaniam * Tony Lindgren <tony@atomide.com> [100222 12:11]: > * Anna, Suman <s-anna@ti.com> [100222 12:04]: > > Hi Santosh, > > > > > -----Original Message----- > > > From: Shilimkar, Santosh > > > Sent: Saturday, February 20, 2010 12:53 PM > > > To: Anna, Suman; linux-omap@vger.kernel.org > > > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > > > Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > > > > -----Original Message----- > > > > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > > > owner@vger.kernel.org] On Behalf Of Anna, > > > > Suman > > > > Sent: Friday, February 19, 2010 2:37 AM > > > > To: linux-omap@vger.kernel.org > > > > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > > > > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > > > > > From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 > > > > From: Suman Anna <s-anna@ti.com> > > > > Date: Tue, 26 Jan 2010 16:55:29 -0600 > > > > Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > > > > > > OMAP4 mailbox has a different register set. There is > > > > no MAILBOX_SYSSTATUS register. The reset is indicated > > > > with the SOFTRESET bit of the MAILBOX_SYSCONFIG register > > > > itself. This bit should read 0 for a successful Reset. > > > > Also, the SOFTRESET bit occupies bit0 and not bit1 as with > > > > previous generations. > > > > > > > > Signed-off-by: Suman Anna <s-anna@ti.com> > > > > --- > > > > arch/arm/mach-omap2/mailbox.c | 38 +++++++++++++++++++++++++++------- > > > ---- > > > > 1 files changed, 27 insertions(+), 11 deletions(-) > > > > > > > > diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach- > > > omap2/mailbox.c > > > > index c970cf6..88e9043 100644 > > > > --- a/arch/arm/mach-omap2/mailbox.c > > > > +++ b/arch/arm/mach-omap2/mailbox.c > > > > @@ -40,6 +40,7 @@ > > > > #define AUTOIDLE (1 << 0) > > > > #define SOFTRESET (1 << 1) > > > > #define SMARTIDLE (2 << 3) > > > > +#define OMAP4_SOFTRESET (1 << 0) > > > > > > > > /* SYSSTATUS: register bit definition */ > > > > #define RESETDONE (1 << 0) > > > > @@ -99,17 +100,32 @@ static int omap2_mbox_startup(struct omap_mbox > > > *mbox) > > > > } > > > > clk_enable(mbox_ick_handle); > > > > > > > > - mbox_write_reg(SOFTRESET, MAILBOX_SYSCONFIG); > > > > - timeout = jiffies + msecs_to_jiffies(20); > > > > - do { > > > > - l = mbox_read_reg(MAILBOX_SYSSTATUS); > > > > - if (l & RESETDONE) > > > > - break; > > > > - } while (!time_after(jiffies, timeout)); > > > > - > > > > - if (!(l & RESETDONE)) { > > > > - pr_err("Can't take mmu out of reset\n"); > > > > - return -ENODEV; > > > > + if (cpu_is_omap44xx()) { > > > Not so strong opinion but can we make use of mailbox ip revision instead > > > of cpu_is_xxxx() check. > > > > > > > This may be a better option in the longer-run, but the current mailbox registers are assigned based on the cpu_is_xxxx() macro, and I have used this readily available macro rather doing a new one. Also, note that the IP revision value is not published in the TRM. > > In the long run the most flexible option is to check the revision > for each device during init. > > Anyways, sounds like that's another patch on top of these patches. As we probably won't have the hwmod patch done for this merge window, I've added these except for the one to fix compile warning. Regards, Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <7E59F0E987E71F40A4E30590884852DC01725109D4@dnce01.ent.ti.com>]
* RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic [not found] ` <7E59F0E987E71F40A4E30590884852DC01725109D4@dnce01.ent.ti.com> @ 2010-02-22 20:14 ` Anna, Suman 0 siblings, 0 replies; 6+ messages in thread From: Anna, Suman @ 2010-02-22 20:14 UTC (permalink / raw) To: Cousson, Benoit, Shilimkar, Santosh, linux-omap@vger.kernel.org Cc: Hiroshi.DOYU@nokia.com, Clark, Rob, Kanigeri, Hari, C.A, Subramaniam Hi Benoit, > -----Original Message----- > From: Cousson, Benoit > Sent: Sunday, February 21, 2010 7:36 AM > To: Shilimkar, Santosh; Anna, Suman; linux-omap@vger.kernel.org > Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > Hi Suman, > > > > Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve > Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 > > -----Original Message----- > > >From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > >owner@vger.kernel.org] On Behalf Of Shilimkar, Santosh > >Sent: Saturday, February 20, 2010 7:53 PM > >To: Anna, Suman; linux-omap@vger.kernel.org > >Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, Subramaniam > >Subject: RE: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > > > >> -----Original Message----- > >> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > >owner@vger.kernel.org] On Behalf Of Anna, > >> Suman > >> Sent: Friday, February 19, 2010 2:37 AM > >> To: linux-omap@vger.kernel.org > >> Cc: Hiroshi.DOYU@nokia.com; Clark, Rob; Kanigeri, Hari; C.A, > Subramaniam > >> Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > >> > >> From 2488815a9facca29e2da3ddd279de441a5de6a58 Mon Sep 17 00:00:00 2001 > >> From: Suman Anna <s-anna@ti.com> > >> Date: Tue, 26 Jan 2010 16:55:29 -0600 > >> Subject: [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic > >> > >> OMAP4 mailbox has a different register set. There is > >> no MAILBOX_SYSSTATUS register. The reset is indicated > >> with the SOFTRESET bit of the MAILBOX_SYSCONFIG register > >> itself. This bit should read 0 for a successful Reset. > >> Also, the SOFTRESET bit occupies bit0 and not bit1 as with > >> previous generations. > > This is due to the new standard defined for OMAP4 IPs and well explain by > Thara in a recently posted patch to handle that smoothly using hwmod. > [PATCH V4] OMAP3: hwmod: support to specify the offset position of various > SYSCONFIG register bits. > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg23509.html > > Is there a reason to not convert the mailbox driver to use hwmod? > It will avoid you to handle that in the mailbox driver code, whereas the > hwmod framework is already taking care of that. > > Regards, > Benoit > Thanks for the reference. Mailbox driver is yet to migrate to use the new hwmod. It is still based on the old framework. Regards Suman ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-22 21:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-18 21:07 [PATCH 2/5] omap: mailbox: correct OMAP4 reset logic Anna, Suman
2010-02-20 18:53 ` Shilimkar, Santosh
2010-02-22 20:07 ` Anna, Suman
2010-02-22 20:15 ` Tony Lindgren
2010-02-22 21:38 ` Tony Lindgren
[not found] ` <7E59F0E987E71F40A4E30590884852DC01725109D4@dnce01.ent.ti.com>
2010-02-22 20:14 ` Anna, Suman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox