RE: [PATCH] musb: fix power field to hold all possible values

Gupta, Ajay Kumar
2010-02-23T14:32:03Z

> -----Original Message-----
> From: Felipe Balbi [mailto:me@felipebalbi.com]
> Sent: Tuesday, February 23, 2010 3:22 PM
> To: Gupta, Ajay Kumar
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] musb: fix power field to hold all possible values
>
> Hi,
>
> On Tue, Feb 23, 2010 at 03:16:44PM +0530, Ajay Kumar Gupta wrote:
> > MUSB can supply upto 500mA such as, AM3517 and OMAP3EVM Rev >=E and thus
> > the 'power' field has to hold values above 255.
>
> power on the arch code is same as bMaxPower it will be multiplied by two
> on musb_core.c. See line 150 of that file.

Agreed but see comment below.

>
> Meaning 500mA is set to 250 on the board-file.

Board files are providing the actual mA and it is getting divided in
Arch/arm/mach-omap2/usb-musb.c. See the code snippet below,

musb_plat.clock = "ick";
musb_plat.board_data = board_data;
--> musb_plat.power = board_data->power >> 1;
musb_plat.mode = board_data->mode;

So we need to either take this patch or fix this logic of dividing the mA
supplied from all omap board files.

-Ajay
>
> --
> balbi