Re: [PATCH 1/9] omap3/4: uart: fix full-fifo write abort

[Tony Lindgren <tony@atomide.com>]

* Shilimkar, Santosh <santosh.shilimkar@ti.com> [100222 23:16]:
> Tony,
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony@atomide.com]
> > Sent: Tuesday, February 23, 2010 4:37 AM
> > To: Shilimkar, Santosh
> > Cc: linux-omap@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Woodruff, Richard; Ghorai,
> > Sukumar
> > Subject: Re: [PATCH 1/9] omap3/4: uart: fix full-fifo write abort
> > 
> > * Tony Lindgren <tony@atomide.com> [100222 13:35]:
> > > * Shilimkar, Santosh <santosh.shilimkar@ti.com> [100218 21:22]:
> > > > Bye the way just to add bit more clarity, this patch addresses TX
> > > > hardware restriction in the new UART IP used on omap3630 and omap4430.
> > > > First part of the fix for RX is already in mainline,
> > > > Commit: "ce13d4716a276f4331d78ba28a5093a63822ab95"
> > > >
> > > > More details on this thread are here.
> > > > http://www.mail-archive.com/linux-omap@vger.kernel.org/msg19447.html
> > >
> > > Thanks, I've updated the comments for this patch with the link above
> > > and added the whole series into omap for-next.
> > 
> > Except patches 8 and 9 as they break compile for mach-omap1
> > and need to be updated.
> >
> Patch 8 is alright and doesn't break omap1. Patch 7 and patch 9 needs update to fix
> the mach-omap1 build issue by moving irqs-44xx.h header file to plat-omap directory.
> Attached are updated 7 and 9.
> Build tested for omap1 (omap_generic_1710_defconfig and omap_h2_1610_defconfig) and boot
> tested with omap3_defconfig on omap4430sdp board.

Next time, one patch per email please. And updates as replies
to the original patches, or else the whole series. And patches
as inline attachments.

Otherwise it's hard to keep track of the patches and comment
them.

I've updated your patch 9/9 with the following as in omap for-next
I was getting:

arch/arm/mach-omap2/usb-musb.c:97: Building for omap_3430sdp_defconfigred (first use in this function)                                                              Building for omap_3630sdp_defconfigch-omap2/usb-musb.c:97: error: (Each undeclared identifier is reported only once
arch/arm/mach-omap2/usb-musb.c:97: error: for each function it appears in.)
arch/arm/mach-omap2/usb-musb.c:98: error: 'INT_44XX_HS_USB_DMA' undeclared (first use in this function)

Regards,

Tony

--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -94,8 +94,8 @@ void __init usb_musb_init(struct omap_musb_board_data *board_data)
 		musb_resources[0].start = OMAP34XX_HSUSB_OTG_BASE;
 	} else if (cpu_is_omap44xx()) {
 		musb_resources[0].start = OMAP44XX_HSUSB_OTG_BASE;
-		musb_resources[1].start = INT_44XX_HS_USB_MC;
-		musb_resources[2].start = INT_44XX_HS_USB_DMA;
+		musb_resources[1].start = OMAP44XX_IRQ_HS_USB_MC_N;
+		musb_resources[2].start = OMAP44XX_IRQ_HS_USB_DMA_N;
 	}
 	musb_resources[0].end = musb_resources[0].start + SZ_4K - 1;