public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jhnikula@gmail.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Peter Ujfalusi <peter.ujfalusi@nokia.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH]  OMAP: McBSP: Drop unnecessary status/error bit clearing on reg_cache retrieved register values
Date: Thu, 4 Mar 2010 08:49:57 +0200	[thread overview]
Message-ID: <20100304084957.28c2a9c9.jhnikula@gmail.com> (raw)
In-Reply-To: <201002231650.40351.jkrzyszt@tis.icnet.pl>

On Tue, 23 Feb 2010 16:50:38 +0100
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> wrote:

> The MsBSP register cache will never have any error/status flags set, since 
> these flags are never written to the reg_cache. So it is kind of not 
> necessary to clear these flags, which are actually always 0.
> 
> In other words, clearing the status/error flags are not necessary, since the 
> reg_cache will never got these bits set. We can just write back the 
> register content from the cache as it is when clearing an error condition.
> 
> Created against l-o for-next commit 62a7c2cc4c8e57e80ccf379536f362fe6e863ac3
> dated 2010-02-22.
> Tested on Amstrad Delta.
> 
> Reported-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> 
Acked-by: Jarkko Nikula <jhnikula@gmail.com>

  reply	other threads:[~2010-03-04  6:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-23 15:50 [PATCH] OMAP: McBSP: Drop unnecessary status/error bit clearing on reg_cache retrieved register values Janusz Krzysztofik
2010-03-04  6:49 ` Jarkko Nikula [this message]
2010-03-04 23:27   ` Janusz Krzysztofik
2010-03-11 22:26 ` [APPLIED] [PATCH] OMAP: McBSP: Drop unnecessary status/error bit clearing on Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100304084957.28c2a9c9.jhnikula@gmail.com \
    --to=jhnikula@gmail.com \
    --cc=jkrzyszt@tis.icnet.pl \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox