From: Felipe Balbi <felipe.balbi@nokia.com>
To: "ext me@felipebalbi.com" <me@felipebalbi.com>
Cc: "Gadiyar, Anand" <gadiyar@ti.com>,
"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@nokia.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook
Date: Fri, 5 Mar 2010 09:03:30 +0200 [thread overview]
Message-ID: <20100305070330.GB12757@nokia.com> (raw)
In-Reply-To: <a05a09f453a7473f2ba54a9056589b72@secure211.sgcpanel.com>
On Thu, Mar 04, 2010 at 08:15:27PM +0100, ext me@felipebalbi.com wrote:
>Hi,
>
>On Thu, 4 Mar 2010 18:33:15 +0530, "Gadiyar, Anand" <gadiyar@ti.com>
>wrote:
>>> This patch fixes that for the ehci_hdc_omap_platform_data.
>>>
>>
>> should be ehci_hcd_omap_platform_data ;)
>>
>> BTW, this breaks compile for omap3-evm.
>> Could you please build with omap3_defconfig and check.
>
>will do first thing tomorrow :-)
yeah, it breaks because evm tries to assign to a (now) const variable.
Maybe the only way is to move everybody out of the __initconst section
and put them on __initdata.
or we drop the revision check for EVM and use only the newer one, I'm
more into doing the first one.
Tony, do you have any comments ??
--
balbi
next prev parent reply other threads:[~2010-03-05 7:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 7:40 [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" felipe.balbi
2010-03-04 7:40 ` [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook felipe.balbi
2010-03-04 7:44 ` Felipe Balbi
2010-03-04 7:45 ` felipe.balbi
2010-03-04 13:03 ` Gadiyar, Anand
2010-03-04 19:15 ` me
2010-03-05 7:03 ` Felipe Balbi [this message]
2010-03-08 23:04 ` Tony Lindgren
2010-03-09 14:30 ` Felipe Balbi
2010-03-09 15:38 ` Tony Lindgren
2010-03-09 15:47 ` Felipe Balbi
2010-03-10 0:48 ` Tony Lindgren
2010-03-10 6:22 ` Felipe Balbi
2010-03-10 17:15 ` Tony Lindgren
2010-03-11 7:28 ` Felipe Balbi
2010-03-11 16:38 ` Tony Lindgren
2010-03-04 7:50 ` [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" Felipe Balbi
2010-03-04 7:57 ` [PATCH 1/2] Manual revert of " felipe.balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305070330.GB12757@nokia.com \
--to=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox