From: Felipe Balbi <me@felipebalbi.com>
To: Scott Ellis <scott@jumpnowtek.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap2_mcspi.c: Clock divider range check wrong for OMAP3
Date: Mon, 8 Mar 2010 17:53:55 +0200 [thread overview]
Message-ID: <20100308155354.GA3867@gandalf> (raw)
In-Reply-To: <1268049411.2558.76.camel@quad>
On Mon, Mar 08, 2010 at 06:56:51AM -0500, Scott Ellis wrote:
> diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
> index fe1b56d..a73127b 100644
> --- a/drivers/spi/omap2_mcspi.c
> +++ b/drivers/spi/omap2_mcspi.c
> @@ -38,8 +38,17 @@
> #include <plat/dma.h>
> #include <plat/clock.h>
>
> +#if defined(CONFIG_ARCH_OMAP3) || defined(CONFIG_ARCH_OMAP4)
> +#define OMAP2_MCSPI_MAX_CLK_DIV 12
> +#else
> +/* could be 12 for OMAP24xxx also, no docs to check */
> +#define OMAP2_MCSPI_MAX_CLK_DIV 15
> +#endif
>
> #define OMAP2_MCSPI_MAX_FREQ 48000000
> +#define OMAP2_MCSPI_MIN_FREQ (OMAP2_MCSPI_MAX_FREQ \
> + / (1 << OMAP2_MCSPI_MAX_CLK_DIV))
please don't break multi-omap builds. Pass this constant using platform_data.
--
balbi
prev parent reply other threads:[~2010-03-08 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 11:56 [PATCH] omap2_mcspi.c: Clock divider range check wrong for OMAP3 Scott Ellis
2010-03-08 12:03 ` Gadiyar, Anand
2010-03-08 15:53 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308155354.GA3867@gandalf \
--to=me@felipebalbi.com \
--cc=linux-omap@vger.kernel.org \
--cc=scott@jumpnowtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox