From: Felipe Balbi <me@felipebalbi.com>
To: Sergio Aguirre <saaguirre@ti.com>
Cc: linux-omap@vger.kernel.org,
Kevin Hilman <khilman@deeprootsystems.com>,
Vikram Pandita <vikram.pandita@ti.com>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [RFC part1/2 merge v2 RESEND][PATCH 04/10] OMAP clock: Add uart4_ick/fck definitions for 3630
Date: Mon, 8 Mar 2010 20:28:44 +0200 [thread overview]
Message-ID: <20100308182843.GE6630@gandalf> (raw)
In-Reply-To: <1268069332-14082-5-git-send-email-saaguirre@ti.com>
On Mon, Mar 08, 2010 at 11:28:46AM -0600, Sergio Aguirre wrote:
> @@ -3420,6 +3440,7 @@ static struct omap_clk omap3xxx_clks[] = {
> CLK(NULL, "per_96m_fck", &per_96m_fck, CK_3XXX),
> CLK(NULL, "per_48m_fck", &per_48m_fck, CK_3XXX),
> CLK(NULL, "uart3_fck", &uart3_fck, CK_3XXX),
> + CLK(NULL, "uart4_fck", &uart4_fck, CK_36XX),
> CLK(NULL, "gpt2_fck", &gpt2_fck, CK_3XXX),
> CLK(NULL, "gpt3_fck", &gpt3_fck, CK_3XXX),
> CLK(NULL, "gpt4_fck", &gpt4_fck, CK_3XXX),
> @@ -3443,6 +3464,7 @@ static struct omap_clk omap3xxx_clks[] = {
> CLK(NULL, "gpio2_ick", &gpio2_ick, CK_3XXX),
> CLK(NULL, "wdt3_ick", &wdt3_ick, CK_3XXX),
> CLK(NULL, "uart3_ick", &uart3_ick, CK_3XXX),
> + CLK(NULL, "uart4_ick", &uart4_ick, CK_36XX),
are the uart clocks shared ? Why not defining the devname here if
they're not ? We would loop less to find the clock that way.
--
balbi
next prev parent reply other threads:[~2010-03-08 18:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 17:28 [RFC part1/2 merge v2 RESEND][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr Sergio Aguirre
2010-03-08 18:24 ` Felipe Balbi
2010-03-08 20:28 ` Aguirre, Sergio
2010-03-08 21:40 ` Kevin Hilman
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 02/10] omap2/3/4: serial: Remove condition for getting uart4_phys Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 03/10] ARM: OMAP3630: PRCM: Add UART4 control bits Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 04/10] OMAP clock: Add uart4_ick/fck definitions for 3630 Sergio Aguirre
2010-03-08 18:28 ` Felipe Balbi [this message]
2010-03-08 20:30 ` Aguirre, Sergio
2010-03-08 21:40 ` Kevin Hilman
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 05/10] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs Sergio Aguirre
2010-03-08 17:55 ` Kevin Hilman
2010-03-08 18:01 ` Aguirre, Sergio
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630 Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 07/10] omap3: zoom2/3 / 3630sdp: Don't init always all uarts Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 08/10] omap3: 3630sdp: Explicitly enable all UARTs Sergio Aguirre
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 09/10] omap3: zoom 2/3: Change debugboard serial port id Sergio Aguirre
2010-03-08 17:59 ` Kevin Hilman
2010-03-08 18:02 ` Aguirre, Sergio
2010-03-08 17:28 ` [RFC part1/2 merge v2 RESEND][PATCH 10/10] omap3: zoom2/3: Register only 1 8250 port Sergio Aguirre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308182843.GE6630@gandalf \
--to=me@felipebalbi.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=saaguirre@ti.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox