Re: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs

[Tony Lindgren <tony@atomide.com>]

* Aggarwal, Anuj <anuj.aggarwal@ti.com> [100302 22:52]:
> > -----Original Message-----
> > From: Grazvydas Ignotas [mailto:notasas@gmail.com]
> > Sent: Tuesday, March 02, 2010 10:54 PM
> > To: Aggarwal, Anuj
> > Cc: tony@atomide.com; linux-omap@vger.kernel.org;
> > broonie@opensource.wolfsonmicro.com; lrg@slimlogic.co.uk
> > Subject: Re: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to
> > choose from available PMICs
> > 
> > On Tue, Mar 2, 2010 at 12:29 PM, Anuj Aggarwal <anuj.aggarwal@ti.com>
> > wrote:
> > > Kconfig is modified for OMAP3 EVM so that user can choose the
> > appropriate
> > > PMIC (currently only TWL4030). Config options for other PMICs will be
> > > added later on.
> > > Makefile is modified so that twl4030-pmic.c gets compiled for the
> > > platforms having TWL4030 as the PMIC.
> > >
> > > Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> > > ---
> > >  arch/arm/mach-omap2/Kconfig  |    9 +++++++++
> > >  arch/arm/mach-omap2/Makefile |    1 +
> > >  2 files changed, 10 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > > index a8a3d1e..1974dda 100644
> > > --- a/arch/arm/mach-omap2/Kconfig
> > > +++ b/arch/arm/mach-omap2/Kconfig
> > > @@ -77,6 +77,15 @@ config MACH_OMAP3EVM
> > >        depends on ARCH_OMAP3
> > >        select OMAP_PACKAGE_CBB
> > >
> > > +config PMIC_TWL4030
> > > +       bool "TWL4030/TPS65950 Power Module"
> > > +       default y
> > > +       select TWL4030_CORE
> > > +       select REGULATOR_TWL4030 if REGULATOR
> > > +       help
> > > +         Say yes here if you are using the TWL4030/TPS65950 based power
> > module
> > > +         for the EVM boards.
> > > +
> > 
> > Any reason to have this user configurable? The boards that depend on
> > it will always need it to be enabled to compile, and the ones that
> > don't always want it disabled.

> [Aggarwal, Anuj] OMAP3 EVM can have different PMICs like TWL4030,
> TPS65023, TPS6507x etc; user can configure the kernel accordingly.

We need to be able to compile in support for multiple PMICs, so
just probe for PMICs via I2C and use the one you find.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html