* [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs
@ 2010-03-02 10:29 Anuj Aggarwal
2010-03-02 17:23 ` Grazvydas Ignotas
0 siblings, 1 reply; 4+ messages in thread
From: Anuj Aggarwal @ 2010-03-02 10:29 UTC (permalink / raw)
To: tony; +Cc: linux-omap, broonie, lrg, Anuj Aggarwal
Kconfig is modified for OMAP3 EVM so that user can choose the appropriate
PMIC (currently only TWL4030). Config options for other PMICs will be
added later on.
Makefile is modified so that twl4030-pmic.c gets compiled for the
platforms having TWL4030 as the PMIC.
Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
arch/arm/mach-omap2/Kconfig | 9 +++++++++
arch/arm/mach-omap2/Makefile | 1 +
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index a8a3d1e..1974dda 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -77,6 +77,15 @@ config MACH_OMAP3EVM
depends on ARCH_OMAP3
select OMAP_PACKAGE_CBB
+config PMIC_TWL4030
+ bool "TWL4030/TPS65950 Power Module"
+ default y
+ select TWL4030_CORE
+ select REGULATOR_TWL4030 if REGULATOR
+ help
+ Say yes here if you are using the TWL4030/TPS65950 based power module
+ for the EVM boards.
+
config MACH_OMAP3517EVM
bool "OMAP3517/ AM3517 EVM board"
depends on ARCH_OMAP3
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
index 2069fb3..c33e24d 100644
--- a/arch/arm/mach-omap2/Makefile
+++ b/arch/arm/mach-omap2/Makefile
@@ -137,6 +137,7 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \
hsmmc.o
obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \
hsmmc.o
+obj-$(CONFIG_PMIC_TWL4030) += twl4030-pmic.o
obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o
obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
--
1.6.2.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs
2010-03-02 10:29 [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs Anuj Aggarwal
@ 2010-03-02 17:23 ` Grazvydas Ignotas
2010-03-03 6:55 ` Aggarwal, Anuj
0 siblings, 1 reply; 4+ messages in thread
From: Grazvydas Ignotas @ 2010-03-02 17:23 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: tony, linux-omap, broonie, lrg
On Tue, Mar 2, 2010 at 12:29 PM, Anuj Aggarwal <anuj.aggarwal@ti.com> wrote:
> Kconfig is modified for OMAP3 EVM so that user can choose the appropriate
> PMIC (currently only TWL4030). Config options for other PMICs will be
> added later on.
> Makefile is modified so that twl4030-pmic.c gets compiled for the
> platforms having TWL4030 as the PMIC.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> arch/arm/mach-omap2/Kconfig | 9 +++++++++
> arch/arm/mach-omap2/Makefile | 1 +
> 2 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index a8a3d1e..1974dda 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -77,6 +77,15 @@ config MACH_OMAP3EVM
> depends on ARCH_OMAP3
> select OMAP_PACKAGE_CBB
>
> +config PMIC_TWL4030
> + bool "TWL4030/TPS65950 Power Module"
> + default y
> + select TWL4030_CORE
> + select REGULATOR_TWL4030 if REGULATOR
> + help
> + Say yes here if you are using the TWL4030/TPS65950 based power module
> + for the EVM boards.
> +
Any reason to have this user configurable? The boards that depend on
it will always need it to be enabled to compile, and the ones that
don't always want it disabled.
> config MACH_OMAP3517EVM
> bool "OMAP3517/ AM3517 EVM board"
> depends on ARCH_OMAP3
> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
> index 2069fb3..c33e24d 100644
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -137,6 +137,7 @@ obj-$(CONFIG_MACH_IGEP0020) += board-igep0020.o \
> hsmmc.o
> obj-$(CONFIG_MACH_OMAP3_TOUCHBOOK) += board-omap3touchbook.o \
> hsmmc.o
> +obj-$(CONFIG_PMIC_TWL4030) += twl4030-pmic.o
> obj-$(CONFIG_MACH_OMAP_4430SDP) += board-4430sdp.o
>
> obj-$(CONFIG_MACH_OMAP3517EVM) += board-am3517evm.o
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs
2010-03-02 17:23 ` Grazvydas Ignotas
@ 2010-03-03 6:55 ` Aggarwal, Anuj
2010-03-08 22:55 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Aggarwal, Anuj @ 2010-03-03 6:55 UTC (permalink / raw)
To: Grazvydas Ignotas
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk
> -----Original Message-----
> From: Grazvydas Ignotas [mailto:notasas@gmail.com]
> Sent: Tuesday, March 02, 2010 10:54 PM
> To: Aggarwal, Anuj
> Cc: tony@atomide.com; linux-omap@vger.kernel.org;
> broonie@opensource.wolfsonmicro.com; lrg@slimlogic.co.uk
> Subject: Re: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to
> choose from available PMICs
>
> On Tue, Mar 2, 2010 at 12:29 PM, Anuj Aggarwal <anuj.aggarwal@ti.com>
> wrote:
> > Kconfig is modified for OMAP3 EVM so that user can choose the
> appropriate
> > PMIC (currently only TWL4030). Config options for other PMICs will be
> > added later on.
> > Makefile is modified so that twl4030-pmic.c gets compiled for the
> > platforms having TWL4030 as the PMIC.
> >
> > Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> > ---
> > arch/arm/mach-omap2/Kconfig | 9 +++++++++
> > arch/arm/mach-omap2/Makefile | 1 +
> > 2 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > index a8a3d1e..1974dda 100644
> > --- a/arch/arm/mach-omap2/Kconfig
> > +++ b/arch/arm/mach-omap2/Kconfig
> > @@ -77,6 +77,15 @@ config MACH_OMAP3EVM
> > depends on ARCH_OMAP3
> > select OMAP_PACKAGE_CBB
> >
> > +config PMIC_TWL4030
> > + bool "TWL4030/TPS65950 Power Module"
> > + default y
> > + select TWL4030_CORE
> > + select REGULATOR_TWL4030 if REGULATOR
> > + help
> > + Say yes here if you are using the TWL4030/TPS65950 based power
> module
> > + for the EVM boards.
> > +
>
> Any reason to have this user configurable? The boards that depend on
> it will always need it to be enabled to compile, and the ones that
> don't always want it disabled.
[Aggarwal, Anuj] OMAP3 EVM can have different PMICs like TWL4030,
TPS65023, TPS6507x etc; user can configure the kernel accordingly.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs
2010-03-03 6:55 ` Aggarwal, Anuj
@ 2010-03-08 22:55 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2010-03-08 22:55 UTC (permalink / raw)
To: Aggarwal, Anuj
Cc: Grazvydas Ignotas, linux-omap@vger.kernel.org,
broonie@opensource.wolfsonmicro.com, lrg@slimlogic.co.uk
* Aggarwal, Anuj <anuj.aggarwal@ti.com> [100302 22:52]:
> > -----Original Message-----
> > From: Grazvydas Ignotas [mailto:notasas@gmail.com]
> > Sent: Tuesday, March 02, 2010 10:54 PM
> > To: Aggarwal, Anuj
> > Cc: tony@atomide.com; linux-omap@vger.kernel.org;
> > broonie@opensource.wolfsonmicro.com; lrg@slimlogic.co.uk
> > Subject: Re: [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to
> > choose from available PMICs
> >
> > On Tue, Mar 2, 2010 at 12:29 PM, Anuj Aggarwal <anuj.aggarwal@ti.com>
> > wrote:
> > > Kconfig is modified for OMAP3 EVM so that user can choose the
> > appropriate
> > > PMIC (currently only TWL4030). Config options for other PMICs will be
> > > added later on.
> > > Makefile is modified so that twl4030-pmic.c gets compiled for the
> > > platforms having TWL4030 as the PMIC.
> > >
> > > Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> > > ---
> > > arch/arm/mach-omap2/Kconfig | 9 +++++++++
> > > arch/arm/mach-omap2/Makefile | 1 +
> > > 2 files changed, 10 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> > > index a8a3d1e..1974dda 100644
> > > --- a/arch/arm/mach-omap2/Kconfig
> > > +++ b/arch/arm/mach-omap2/Kconfig
> > > @@ -77,6 +77,15 @@ config MACH_OMAP3EVM
> > > depends on ARCH_OMAP3
> > > select OMAP_PACKAGE_CBB
> > >
> > > +config PMIC_TWL4030
> > > + bool "TWL4030/TPS65950 Power Module"
> > > + default y
> > > + select TWL4030_CORE
> > > + select REGULATOR_TWL4030 if REGULATOR
> > > + help
> > > + Say yes here if you are using the TWL4030/TPS65950 based power
> > module
> > > + for the EVM boards.
> > > +
> >
> > Any reason to have this user configurable? The boards that depend on
> > it will always need it to be enabled to compile, and the ones that
> > don't always want it disabled.
> [Aggarwal, Anuj] OMAP3 EVM can have different PMICs like TWL4030,
> TPS65023, TPS6507x etc; user can configure the kernel accordingly.
We need to be able to compile in support for multiple PMICs, so
just probe for PMICs via I2C and use the one you find.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-08 22:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 10:29 [PATCHv3 2/4] Regulator: OMAP: Modifying Kconfig/Makefile to choose from available PMICs Anuj Aggarwal
2010-03-02 17:23 ` Grazvydas Ignotas
2010-03-03 6:55 ` Aggarwal, Anuj
2010-03-08 22:55 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox