From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: Felipe Balbi <felipe.balbi@nokia.com>,
"Gadiyar, Anand" <gadiyar@ti.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook
Date: Tue, 9 Mar 2010 07:38:27 -0800 [thread overview]
Message-ID: <20100309153827.GR2900@atomide.com> (raw)
In-Reply-To: <20100309143020.GA12260@gandalf>
* Felipe Balbi <me@felipebalbi.com> [100309 06:27]:
> Hi,
>
> On Mon, Mar 08, 2010 at 03:04:23PM -0800, Tony Lindgren wrote:
> > Hmm yeah thanks for digging into this mystery. Looks like we're
> > hitting some Linux initdata limitation.
> >
> > We can't mark everything as __initconst. Some platform data can
> > get dynamically set based on the board type for resources.
> >
> > So to me it sounds like the only solution is to mark everything
> > as __initdata and ignore the (correct) const for now for __initdata.
> >
> > Or am I missing something?
>
> sure. I'll cook something. But then it means all ehci_hcd_platform_data
> won't be able to be declared as const or that might cause problems as
> well later.
But sounds like your fix to mark anything going to init.rodata as const
is correct since it is rodata. I was originally thinking this is somehow
related to __init vs __initconst, but it's for __initconst only, and
we should use const there as it's read only.
Let me take another look at your patches and make sure everything
compiles OK, I don't think we're using __initconst in that many places.
Regards,
Tony
next prev parent reply other threads:[~2010-03-09 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 7:40 [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" felipe.balbi
2010-03-04 7:40 ` [PATCH 2/2] arm: omap: ehci: avoid compiler error with touchbook felipe.balbi
2010-03-04 7:44 ` Felipe Balbi
2010-03-04 7:45 ` felipe.balbi
2010-03-04 13:03 ` Gadiyar, Anand
2010-03-04 19:15 ` me
2010-03-05 7:03 ` Felipe Balbi
2010-03-08 23:04 ` Tony Lindgren
2010-03-09 14:30 ` Felipe Balbi
2010-03-09 15:38 ` Tony Lindgren [this message]
2010-03-09 15:47 ` Felipe Balbi
2010-03-10 0:48 ` Tony Lindgren
2010-03-10 6:22 ` Felipe Balbi
2010-03-10 17:15 ` Tony Lindgren
2010-03-11 7:28 ` Felipe Balbi
2010-03-11 16:38 ` Tony Lindgren
2010-03-04 7:50 ` [PATCH 1/2] Revert "omap: Fix compile for early_param and omap_smc1" Felipe Balbi
2010-03-04 7:57 ` [PATCH 1/2] Manual revert of " felipe.balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309153827.GR2900@atomide.com \
--to=tony@atomide.com \
--cc=felipe.balbi@nokia.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox