From: Felipe Balbi <me@felipebalbi.com>
To: "Aguirre, Sergio" <saaguirre@ti.com>
Cc: "me@felipebalbi.com" <me@felipebalbi.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
"Pandita, Vikram" <vikram.pandita@ti.com>,
Paul Walmsley <paul@pwsan.com>, Tony Lindgren <tony@atomide.com>
Subject: Re: [RFC part1/2 merge v3][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr
Date: Tue, 9 Mar 2010 19:39:33 +0200 [thread overview]
Message-ID: <20100309173933.GA3866@gandalf> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894453E4D72D@dlee02.ent.ti.com>
Hi,
On Tue, Mar 09, 2010 at 10:30:08AM -0600, Aguirre, Sergio wrote:
> Ok, I didn't do that, since there are other printks in the same function.
>
> I can change it here, no problem.
>
> I guess I can add a separate patch to standardize and change all
> printks to dev_* macros... would that make sense?
sure that would make more sense :-)
> > change printk() + WARN_ON() into:
> >
> > WARN(1, "%s: can't init uart%d, no clocks available\n",
> > koject_name(&dev->kobj), port);
>
> That looks nicer. Thanks!
np
--
balbi
next prev parent reply other threads:[~2010-03-09 17:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 16:16 [RFC part1/2 merge v3][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 01/10] OMAP3: serial: Check for zero-based physical addr Sergio Aguirre
2010-03-09 16:21 ` Felipe Balbi
2010-03-09 16:30 ` Aguirre, Sergio
2010-03-09 17:39 ` Felipe Balbi [this message]
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 02/10] omap2/3/4: serial: Remove condition for getting uart4_phys Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 03/10] ARM: OMAP3630: PRCM: Add UART4 control bits Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 04/10] OMAP clock: Add uart4_ick/fck definitions for 3630 Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 05/10] OMAP3: PRCM: Consider UART4 for 3630 chip in prcm_setup_regs Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 06/10] omap3: serial: Fix uart4 handling for 3630 Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 07/10] omap3: zoom2/3 / 3630sdp: Don't init always all uarts Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 08/10] omap3: 3630sdp: Explicitly enable all UARTs Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 09/10] omap3: zoom 2/3: Change debugboard serial port id Sergio Aguirre
2010-03-09 16:16 ` [RFC part1/2 merge v3][PATCH 10/10] omap3: zoom2/3: Register only 1 8250 port Sergio Aguirre
2010-03-09 16:33 ` [RFC part1/2 merge v3][PATCH 00/10] omap2/3/4: uart4 fixes + zoom2/3 changes Aguirre, Sergio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309173933.GA3866@gandalf \
--to=me@felipebalbi.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=saaguirre@ti.com \
--cc=tony@atomide.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox