* Felipe Balbi [100309 07:44]: > On Tue, Mar 09, 2010 at 07:38:27AM -0800, Tony Lindgren wrote: > > But sounds like your fix to mark anything going to init.rodata as const > > is correct since it is rodata. I was originally thinking this is somehow > > related to __init vs __initconst, but it's for __initconst only, and > > we should use const there as it's read only. > > > > Let me take another look at your patches and make sure everything > > compiles OK, I don't think we're using __initconst in that many places. > > the problem is when you put const and non-const variables inside > .init.rodata section. gcc manual might have something about that. Here's an updated version of your patch with some compile fixes and using just __init in a few places where ehci_pdata is not const. Regards, Tony