From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig Date: Wed, 10 Mar 2010 12:27:02 -0600 Message-ID: <20100310182702.GA31494@lixom.net> References: <1267079758-14480-1-git-send-email-x0082077@ti.com> <20100225184833.GG28173@atomide.com> <20100226004233.GA3241@lixom.net> <000001cab6bf$5df75720$808918ac@apr.dhcp.ti.com> <20100226185414.GA10835@lixom.net> <001b01cab901$dadec9a0$808918ac@apr.dhcp.ti.com> <20100301154329.GA4154@lixom.net> <00f701cac03a$da51cab0$808918ac@apr.dhcp.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <00f701cac03a$da51cab0$808918ac-wD+IZp/g4/2mHdYHvhjUOg@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maulik Cc: 'Tony Lindgren' , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Felipe Balbi' , 'Greg Kroah-Hartman' , 'David Brownell' List-Id: linux-omap@vger.kernel.org On Wed, Mar 10, 2010 at 03:47:08PM +0530, Maulik wrote: > > >Hmm. I must be missing something, but it looks odd to have both the > >USB_MUSB_HDRC and USB_MUSB_SOC high-level config options, especially since > >the depends are duplicated across them. > > >In general, options like these tend to scale badly: > > >config USB_MUSB_SOC > > boolean > > depends on USB_MUSB_HDRC > > default y if ARCH_DAVINCI > > default y if ARCH_OMAP2430 > > default y if ARCH_OMAP34XX > > default y if (BF54x && !BF544) > > default y if (BF52x && !BF522 && !BF523) > > >I.e. every single platform needs to add a new line. It's better > >to have a config option that is selected from the platform code > >(arch/arm/mach-omap2/Kconfig for the specific SOC in this case), that > > Olof, > > I agree with this. Since this change will impact many platforms it will > require thorough testing and review. Can we have OMAP4 MUSB driver support > queued up without this Kconfig enhancement? I believe the driver patches can > go in independent of this enhancement. Yeah, they can go in. It was more a comment in case someone's looking for janitorial things to do. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html