Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

Olof Johansson
2010-02-26T18:47:54Z

On Fri, Feb 26, 2010 at 02:10:31PM +0530, Maulik wrote:

> >>Adding more and more depends also doesn't scale well. It's time for
> >>someone to switch the test around, add a ARCH_HAS_MUSB, select it on
> >>the platforms that has it and make the config option depend on that,
> >>similar to how (some) platforms to EHCI today.
>
> >>(i.e. if there's a janitor out there reading this, feel free to go ahead
> >>and do it. :-)
>
> Olof,
>
> We have such an option "USB_MUSB_SOC" that takes care of all platforms where
> MUSB is present. But the Inventra DMA case is typical. Not all architectures
> that have MUSB use Inventra DMA for e.g Davinci uses CPPI DMA.

Yeah, sorry. I didn't mean the INVENTRA_DMA config option as much as the top
MUSB one. So you should be able to switch to that instead of adding a check for
OMAP4 there then?

-Olof