RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

Maulik
2010-02-26T08:40:49Z

> > @@ -153,7 +157,7 @@ config MUSB_PIO_ONLY
> > config USB_INVENTRA_DMA
> > bool
> > depends on USB_MUSB_HDRC && !MUSB_PIO_ONLY
> > - default ARCH_OMAP2430 || ARCH_OMAP34XX || BLACKFIN
> > + default ARCH_OMAP2430 || ARCH_OMAP34XX || BLACKFIN || ARCH_OMAP4
> > help
> > Enable DMA transfers using Mentor's engine.
>
> FYI, this needs to be updated as I have patches queued up
> to replace ARCH_OMAP34XX and with ARCH_OMAP3. You might
> want to check all these patches for that and make sure
> they build and work with the omap-for-linus branch.

Tony,

I shall post a newer version after rebasing and fixing the comments.
I believe your patches will soon make to mainline :-)

>>Adding more and more depends also doesn't scale well. It's time for
>>someone to switch the test around, add a ARCH_HAS_MUSB, select it on
>>the platforms that has it and make the config option depend on that,
>>similar to how (some) platforms to EHCI today.

>>(i.e. if there's a janitor out there reading this, feel free to go ahead
>>and do it. :-)

Olof,

We have such an option "USB_MUSB_SOC" that takes care of all platforms where
MUSB is present. But the Inventra DMA case is typical. Not all architectures
that have MUSB use Inventra DMA for e.g Davinci uses CPPI DMA.

Thanks,
Maulik