From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-omap@vger.kernel.org, Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH 2/2] OMAP4: fix temporary hacks that break multi-omap PM
Date: Wed, 10 Mar 2010 13:42:32 -0800 [thread overview]
Message-ID: <20100310214231.GO2900@atomide.com> (raw)
In-Reply-To: <1268241391-26312-3-git-send-email-khilman@deeprootsystems.com>
* Kevin Hilman <khilman@deeprootsystems.com> [100310 09:16]:
> When building for multi-omap, and OMAP4 is enabled, CONFIG_ARCH_OMAP4
> will be true and prevent included code from building/running for
> OMAP2/3 as well.
>
> This problem exists in io.c where some hwmod/PM/SDRC init code is
> prevented from running even on OMAP2/3 when OMAP4 is included in a
> multi-OMAP build.
>
> A quick glance suggests that this #ifndef is no longer needed in most
> of the cases. In the remaining cases, the function is wrapped with
> "if (cpu_is_omap24xx() || cpu_is_omap34xx())" which will be optimized
> out for OMAP4-only builds.
>
> Note that this is only a short-term fix. Longer-term, OMAP4
> needs to create init functions for SDRC and hwmod late-init.
Good to get rid of the temporary hacks. Santosh, maybe grep
to see if there are other hacks left that can be now removed?
Regards,
Tony
next prev parent reply other threads:[~2010-03-10 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 17:16 [PATCH 0/2] fixes for broken PM init with multi-OMAP Kevin Hilman
2010-03-10 17:16 ` [PATCH 1/2] OMAP2: cpu_is_omap2*: fix compile-time removal of unused code Kevin Hilman
2010-03-11 22:12 ` [APPLIED] [PATCH 1/2] OMAP2: cpu_is_omap2*: fix compile-time removal of Tony Lindgren
2010-03-10 17:16 ` [PATCH 2/2] OMAP4: fix temporary hacks that break multi-omap PM Kevin Hilman
2010-03-10 21:42 ` Tony Lindgren [this message]
2010-03-10 21:49 ` Kevin Hilman
2010-03-11 5:12 ` Shilimkar, Santosh
2010-03-11 22:12 ` [APPLIED] " Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310214231.GO2900@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox