From: Tony Lindgren <tony@atomide.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: Fixing build warning with omap3_defconfig
Date: Thu, 11 Mar 2010 14:23:53 -0800 [thread overview]
Message-ID: <20100311222353.GO2900@atomide.com> (raw)
In-Reply-To: <1267527368-19690-1-git-send-email-anuj.aggarwal@ti.com>
* Anuj Aggarwal <anuj.aggarwal@ti.com> [100302 02:52]:
> Fixes the below build warning when compiled with omap3_defconfig:
>
> CC arch/arm/mach-omap2/board-am3517evm.o
> In file included from arch/arm/mach-omap2/board-am3517evm.c:23:
> include/linux/i2c/pca953x.h:14: warning: 'struct i2c_client' declared
> inside parameter list
> include/linux/i2c/pca953x.h:14: warning: its scope is only this definition
> or declaration, which is probably not what you want
> include/linux/i2c/pca953x.h:17: warning: 'struct i2c_client' declared inside
> parameter list
> CC arch/arm/mach-omap2/usb-musb.o
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
> include/linux/i2c/pca953x.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/i2c/pca953x.h b/include/linux/i2c/pca953x.h
> index 81736d6..6c8f853 100644
> --- a/include/linux/i2c/pca953x.h
> +++ b/include/linux/i2c/pca953x.h
> @@ -1,4 +1,5 @@
> /* platform data for the PCA9539 16-bit I/O expander driver */
> +#include <linux/i2c.h>
>
> struct pca953x_platform_data {
> /* number of the first GPIO */
>
This needs to go via the I2C list.
Tony
prev parent reply other threads:[~2010-03-11 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 10:56 [PATCH] OMAP: Fixing build warning with omap3_defconfig Anuj Aggarwal
2010-03-11 22:23 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311222353.GO2900@atomide.com \
--to=tony@atomide.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox