public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP: Fixing build warning with omap3_defconfig
@ 2010-03-02 10:56 Anuj Aggarwal
  2010-03-11 22:23 ` Tony Lindgren
  0 siblings, 1 reply; 2+ messages in thread
From: Anuj Aggarwal @ 2010-03-02 10:56 UTC (permalink / raw)
  To: linux-omap; +Cc: tony, Anuj Aggarwal

Fixes the below build warning when compiled with omap3_defconfig:

  CC      arch/arm/mach-omap2/board-am3517evm.o
  In file included from arch/arm/mach-omap2/board-am3517evm.c:23:
  include/linux/i2c/pca953x.h:14: warning: 'struct i2c_client' declared
  	inside parameter list
  include/linux/i2c/pca953x.h:14: warning: its scope is only this definition
  	or declaration, which is probably not what you want
  include/linux/i2c/pca953x.h:17: warning: 'struct i2c_client' declared inside
  	parameter list
  CC      arch/arm/mach-omap2/usb-musb.o

Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
 include/linux/i2c/pca953x.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/i2c/pca953x.h b/include/linux/i2c/pca953x.h
index 81736d6..6c8f853 100644
--- a/include/linux/i2c/pca953x.h
+++ b/include/linux/i2c/pca953x.h
@@ -1,4 +1,5 @@
 /* platform data for the PCA9539 16-bit I/O expander driver */
+#include <linux/i2c.h>
 
 struct pca953x_platform_data {
 	/* number of the first GPIO */
-- 
1.6.2.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] OMAP: Fixing build warning with omap3_defconfig
  2010-03-02 10:56 [PATCH] OMAP: Fixing build warning with omap3_defconfig Anuj Aggarwal
@ 2010-03-11 22:23 ` Tony Lindgren
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2010-03-11 22:23 UTC (permalink / raw)
  To: Anuj Aggarwal; +Cc: linux-omap

* Anuj Aggarwal <anuj.aggarwal@ti.com> [100302 02:52]:
> Fixes the below build warning when compiled with omap3_defconfig:
> 
>   CC      arch/arm/mach-omap2/board-am3517evm.o
>   In file included from arch/arm/mach-omap2/board-am3517evm.c:23:
>   include/linux/i2c/pca953x.h:14: warning: 'struct i2c_client' declared
>   	inside parameter list
>   include/linux/i2c/pca953x.h:14: warning: its scope is only this definition
>   	or declaration, which is probably not what you want
>   include/linux/i2c/pca953x.h:17: warning: 'struct i2c_client' declared inside
>   	parameter list
>   CC      arch/arm/mach-omap2/usb-musb.o
> 
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
> ---
>  include/linux/i2c/pca953x.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/i2c/pca953x.h b/include/linux/i2c/pca953x.h
> index 81736d6..6c8f853 100644
> --- a/include/linux/i2c/pca953x.h
> +++ b/include/linux/i2c/pca953x.h
> @@ -1,4 +1,5 @@
>  /* platform data for the PCA9539 16-bit I/O expander driver */
> +#include <linux/i2c.h>
>  
>  struct pca953x_platform_data {
>  	/* number of the first GPIO */
> 

This needs to go via the I2C list.

Tony

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-11 22:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 10:56 [PATCH] OMAP: Fixing build warning with omap3_defconfig Anuj Aggarwal
2010-03-11 22:23 ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox