From: Tony Lindgren <tony@atomide.com>
To: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Cc: linux-omap@vger.kernel.org, scott@jumpnowtek.com, gadiyar@ti.com
Subject: Re: [PATCH 1/2] omap2_mcspi: Flush posted writes
Date: Thu, 11 Mar 2010 14:40:43 -0800 [thread overview]
Message-ID: <20100311224043.GS2900@atomide.com> (raw)
In-Reply-To: <1268216316-32552-1-git-send-email-roman.tereshonkov@nokia.com>
* Roman Tereshonkov <roman.tereshonkov@nokia.com> [100310 02:16]:
> mcspi_write_chconf0 is used to control rx/tx triggering.
> Post-write flushing is needed to get the immediate effect.
>
> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
> ---
> drivers/spi/omap2_mcspi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/spi/omap2_mcspi.c b/drivers/spi/omap2_mcspi.c
> index 715c518..35b31fe 100644
> --- a/drivers/spi/omap2_mcspi.c
> +++ b/drivers/spi/omap2_mcspi.c
> @@ -203,6 +203,7 @@ static inline void mcspi_write_chconf0(const struct spi_device *spi, u32 val)
>
> cs->chconf0 = val;
> mcspi_write_cs_reg(spi, OMAP2_MCSPI_CHCONF0, val);
> + mcspi_read_cs_reg(spi, OMAP2_MCSPI_CHCONF0);
> }
>
> static void omap2_mcspi_set_dma_req(const struct spi_device *spi,
Looks like good fixes, these should be resent to the
spi list and maintainers. See the MAINTAINERS file.
Regards,
Tony
prev parent reply other threads:[~2010-03-11 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 10:18 [PATCH 1/2] omap2_mcspi: Flush posted writes Roman Tereshonkov
2010-03-10 10:18 ` [PATCH 2/2] omap2_mcspi: small fixes of output data format Roman Tereshonkov
2010-03-11 22:40 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100311224043.GS2900@atomide.com \
--to=tony@atomide.com \
--cc=gadiyar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=roman.tereshonkov@nokia.com \
--cc=scott@jumpnowtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox